See the attached test case. Basically a tab character shouldn't expand to 0 spaces, it should become 8 spaces in that case. This is a regression.
Created attachment 308965 [details] test case with correct and incorrect rendering as ascii art Curses! Bugzilla didn't get it the first time (as part of filing this report) and asked me to try again, and I don't recall seeing any warning the second time around. Alright, attached now :-)
Hmm, should be easy to fix
That's what I was hoping to hear :-)
10 years ago
Created attachment 309853 [details] [diff] [review] fix The problem is that we were multiplying the space width by 8 before converting to appunits and rounding to get the tab width, which gives different (and sometimes smaller) results than converting the character width to appunits and then multiplying by 8, which is what we actually get when we put 8 characters together.
10 years ago
Comment on attachment 309853 [details] [diff] [review] fix Do you need the |spaceWidthAppUnits| intermediate? Also, maybe add spaces around |*|?
(In reply to comment #6) > (From update of attachment 309853 [details] [diff] [review]) > Do you need the |spaceWidthAppUnits| intermediate? Not really, but it's helpful documentation. > Also, maybe add spaces around |*|? I don't think we have style guidelines for that. I like * to bind tightly just like in real mathematics.
verified fixed using the testcase and Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032615 Firefox/3.0b5pre ID:2008032615