422465 - cloning a bug should cc the original reporter if the cloner isn't the reporter

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, enhancement, P2)

Description

[timeless]

see bug 422287 and bug 422137 comment 10

Comment 1

[Max Kanat-Alexander]

Sure, that sounds sensible to me.

Comment 2

[Alex Eiser]

Attachment: Proposed Patch

Comment 3

[Alex Eiser]

Comment on attachment 351967 [details] [diff] [review]
Proposed Patch

Wrong bug.

Comment 4

[Nitish Bezzala]

Attachment: cloning a bug should cc the original reporter if the cloner isn't the reporter

Comment 5

[Max Kanat-Alexander]

Comment on attachment 354668 [details] [diff] [review]
cloning a bug should cc the original reporter if the cloner isn't the reporter

Don't you think it would be confusing to have a comma-separated list and then suddenly another item with a space? This is what join() is for. Also, put the reporter at the beginning, so people notice. You're doing something that the user didn't explicitly ask you to do, so it needs to be obvious.

Comment 6

[Nitish Bezzala]

Attachment: Added reporter in the beggining, used join

Comment 7

[Max Kanat-Alexander]

Comment on attachment 354780 [details] [diff] [review]
Added reporter in the beggining, used join

It's their login that goes there, not their email. (Sometimes these are different things.)

Also, you should just be comparing user ids, not their emails.

Comment 8

[Nitish Bezzala]

Attachment: Used login and id instead of email

Comment 9

[Max Kanat-Alexander]

Comment on attachment 354833 [details] [diff] [review]
Used login and id instead of email

You should be joining with a comma. Did you see comment 5?

Comment 10

[Nitish Bezzala]

Attachment: joining with a comma

Yes, I saw comment 5, but I thought you were explaining why I should use join. Also, I didn't join with a comma because the line above didn't use a comma. Now, I've changed both the lines.

Comment 11

[Max Kanat-Alexander]

Comment on attachment 354919 [details] [diff] [review]
joining with a comma

Looks good.

Comment 12

[Frédéric Buclin]

Please attach a working patch:

patch: **** unexpected end of file in patch


The context is clearly wrong.

Comment 13

[Nitish Bezzala]

Attachment: i think the context is correct now. sorry.

Comment 14

[Frédéric Buclin]

Comment on attachment 355104 [details] [diff] [review]
i think the context is correct now. sorry.

OK, the patch applies cleanly now. Carrying forward mkanat's r+ (my r+ is just to mean the patch applies cleanly).

Comment 15

[Frédéric Buclin]

Checking in enter_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/enter_bug.cgi,v  <--  enter_bug.cgi
new revision: 1.167; previous revision: 1.166
done