42249 - res handler not resolving location correctly.

Status: VERIFIED FIXED

(Core :: Networking, defect, P3)

Description

[Judson Valeski]

from adam:

It appears that when Gecko tries to first load a URL, it loads this agent style
sheet: 

res://res/ua.css 

The res channel resolves this into a local file name, e.g. 

d:\mozilla\bin\res\ua.css 

And then loads it up. 

Unfortunately, if the host app is not running from d:\mozilla\bin, the resolved
path is wrong! Embedding apps such as CBrowse
run from elsewhere so that the URL is resolved to something like: 

d:\cbrowse\debug\res\ua.css 

The agent stylesheet file isn't there so no content is displayed and there are
asserts everywhere. 

I believe the reason for this is that the nsResProtocolHandler class mistakenly
does this at the start of its Init() method: 

  // make "res:///" == "resource:/" 
  rv = SetSpecialDir("", "system.OS_CurrentProcessDirectory"); 
  if (NS_FAILED(rv)) return rv; 

It's using the current working directory for resolving res files and not the
Mozilla bin directory. Fortunately the fix is easy.
Change the "system.OS_CurrentProcessDirectory" to "xpcom.currentProcess". 

There's also a questionable call at the end of Init() that may also need
changing: 

  // Set up the "Resource" root to point to the old resource location 
  // such that: 
  //     resource://<path>  ==  res://Resource/<path> 
  rv = SetSpecialDir("Resource", "system.OS_CurrentProcessDirectory"); 
  if (NS_FAILED(rv)) return rv;

Comment 1

[Judson Valeski]

-> beta2. this is asserting embedding apps

Comment 2

[Warren Harris]

All these special directory names are unspecified (you have to dig through the 
source), so it's no wonder there's a problem here. Please check in the change to 
xpcom.currentProcess if that works.

Comment 3

[locka]

Attachment: Tiny patch will go in tomorrow, but is attached here for comments (if any)

Comment 4

[locka]

Fix checked in

Comment 5

[benc]

VERIFIED/lxr:
http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=nsResProtocolHandler.cpp&root=/cvsroot&subdir=mozilla/netwerk/protocol/res/src&command=DIFF_FRAMESET&rev1=1.16&rev2=1.17