Closed
Bug 422591
Opened 16 years ago
Closed 16 years ago
nsNotifyAddrListener shuts down its worker thread in response to the wrong observer topic
Categories
(Core :: Networking, defect, P2)
Tracking
()
RESOLVED
FIXED
mozilla1.9
People
(Reporter: bent.mozilla, Assigned: mayhemer)
Details
Attachments
(1 file)
2.50 KB,
patch
|
Biesinger
:
review+
|
Details | Diff | Splinter Review |
nsNotifyAddrListener shuts down its worker thread in response to the wrong observer topic. It's currently using NS_XPCOM_SHUTDOWN_OBSERVER_ID and it should be using NS_XPCOM_SHUTDOWN_THREADS_OBSERVER_ID.
Flags: blocking1.9?
Comment 1•16 years ago
|
||
bent: what's the impact here?
Reporter | ||
Comment 2•16 years ago
|
||
I guess it could cause weird crashes due to races. Basically the thread manager expects all threads to be joined in response to shutdown_threads and this class is shutting its thread down afterwards.
Assignee | ||
Comment 5•16 years ago
|
||
Changed the topic name and tested. There is no public define for the topic name..
Attachment #310963 -
Flags: review?(ted.mielczarek)
Comment 6•16 years ago
|
||
Comment on attachment 310963 [details] [diff] [review] Fix I'm not a network peer...
Attachment #310963 -
Flags: review?(ted.mielczarek) → review?(cbiesinger)
Updated•16 years ago
|
Attachment #310963 -
Flags: review?(cbiesinger) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #310963 -
Flags: approval1.9?
Updated•16 years ago
|
Attachment #310963 -
Flags: approval1.9?
Updated•16 years ago
|
Keywords: checkin-needed
Comment 7•16 years ago
|
||
Checking in netwerk/system/win32/nsNotifyAddrListener.cpp; /cvsroot/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp,v <-- nsNotifyAddrListener.cpp new revision: 1.9; previous revision: 1.8 done
Status: NEW → RESOLVED
Closed: 16 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in
before you can comment on or make changes to this bug.
Description
•