Closed Bug 422591 Opened 13 years ago Closed 13 years ago

nsNotifyAddrListener shuts down its worker thread in response to the wrong observer topic

Categories

(Core :: Networking, defect, P2)

x86
Windows XP
defect

Tracking

()

RESOLVED FIXED
mozilla1.9

People

(Reporter: bent.mozilla, Assigned: mayhemer)

Details

Attachments

(1 file)

nsNotifyAddrListener shuts down its worker thread in response to the wrong observer topic. It's currently using NS_XPCOM_SHUTDOWN_OBSERVER_ID and it should be using NS_XPCOM_SHUTDOWN_THREADS_OBSERVER_ID.
Flags: blocking1.9?
bent: what's the impact here?
I guess it could cause weird crashes due to races. Basically the thread manager expects all threads to be joined in response to shutdown_threads and this class is shutting its thread down afterwards.
Yep - let's fix... +p2
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
will take a look at this.
Assignee: nobody → honzab
Attached patch FixSplinter Review
Changed the topic name and tested. There is no public define for the topic name..
Attachment #310963 - Flags: review?(ted.mielczarek)
Comment on attachment 310963 [details] [diff] [review]
Fix

I'm not a network peer...
Attachment #310963 - Flags: review?(ted.mielczarek) → review?(cbiesinger)
Attachment #310963 - Flags: review?(cbiesinger) → review+
Attachment #310963 - Flags: approval1.9?
Attachment #310963 - Flags: approval1.9?
Checking in netwerk/system/win32/nsNotifyAddrListener.cpp;
/cvsroot/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp,v  <--  nsNotifyAddrListener.cpp
new revision: 1.9; previous revision: 1.8
done
Status: NEW → RESOLVED
Closed: 13 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9
You need to log in before you can comment on or make changes to this bug.