422591 - nsNotifyAddrListener shuts down its worker thread in response to the wrong observer topic

Status: RESOLVED FIXED

(Core :: Networking, defect, P2)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

nsNotifyAddrListener shuts down its worker thread in response to the wrong observer topic. It's currently using NS_XPCOM_SHUTDOWN_OBSERVER_ID and it should be using NS_XPCOM_SHUTDOWN_THREADS_OBSERVER_ID.

Comment 1

[(not currently active) Ted Mielczarek]

bent: what's the impact here?

Comment 2

[Ben Turner (not reading bugmail, use the needinfo flag!)]

I guess it could cause weird crashes due to races. Basically the thread manager expects all threads to be joined in response to shutdown_threads and this class is shutting its thread down afterwards.

Comment 3

[Mike Schroepfer]

Yep - let's fix... +p2

Comment 4

[Honza Bambas (:mayhemer)]

will take a look at this.

Comment 5

[Honza Bambas (:mayhemer)]

Attachment: Fix

Changed the topic name and tested. There is no public define for the topic name..

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 310963 [details] [diff] [review]
Fix

I'm not a network peer...

Comment 7

[Reed Loden [:reed]]

Checking in netwerk/system/win32/nsNotifyAddrListener.cpp;
/cvsroot/mozilla/netwerk/system/win32/nsNotifyAddrListener.cpp,v  <--  nsNotifyAddrListener.cpp
new revision: 1.9; previous revision: 1.8
done