Closed Bug 422592 Opened 12 years ago Closed 12 years ago

js.c dis/dissrc kill script execution

Categories

(Core :: JavaScript Engine, defect)

x86
All
defect
Not set

Tracking

()

RESOLVED FIXED

People

(Reporter: timeless, Assigned: timeless)

References

Details

Attachments

(2 files, 1 obsolete file)

Attached patch uncatchable errors are bad (obsolete) — Splinter Review
I was hoping to do either:
dis(print);1
or
try{dissrc(print);} catch (e){};1

but neither work.

(this can be tested in js shell and jsdb, but not xpcshell)
Flags: in-testsuite?
Flags: blocking1.8.0.15?
Attachment #309048 - Flags: review?(shaver)
Comment on attachment 309048 [details] [diff] [review]
uncatchable errors are bad

Probably won't get to this until RC1.  (I can't imagine a world in which we'd block 1.8.0.15 on such a fix, to be honest, but I'll let those drivers sort it out.)
for check in when the bug is fixed.
OS: Windows XP → All
Attachment #309048 - Flags: review?(mrbkap)
Comment on attachment 309048 [details] [diff] [review]
uncatchable errors are bad

r=shaver
Attachment #309048 - Flags: review?(shaver)
Attachment #309048 - Flags: review?(mrbkap)
Attachment #309048 - Flags: review+
/cvsroot/mozilla/js/tests/public-failures.txt,v  <--  public-failures.txt
new revision: 1.76; previous revision: 1.75

/cvsroot/mozilla/js/tests/js1_5/extensions/regress-422592.js,v  <--  regress-422592.js
initial revision: 1.1

changeset:   15654:397a1c47022e

Is this fixed now?
Attached patch Updated to tipSplinter Review
Attachment #309048 - Attachment is obsolete: true
Attachment #329434 - Flags: review+
Pushed as changeset 306d738a3e40.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Depends on: 445743
Comment on attachment 329434 [details] [diff] [review]
Updated to tip

>+MSG_DEF(JSSMSG_SCRIPTS_ONLY,             7, 0, JSEXN_NONE, "only works on JS scripts") 
>+MSG_DEF(JSSMSG_CANT_DISASSEMBLE,         8, 0, JSEXN_NONE, "Could not disassemble script")

"works only", not "only works"

"JS scripts" should just be scripts, like the second addition -- unless you mean works only on Script objects, in which case say that. r=me ahead of the patch.

/be
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.