422592 - js.c dis/dissrc kill script execution

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[timeless]

Attachment: uncatchable errors are bad

I was hoping to do either:
dis(print);1
or
try{dissrc(print);} catch (e){};1

but neither work.

(this can be tested in js shell and jsdb, but not xpcshell)

Comment 1

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 309048 [details] [diff] [review]
uncatchable errors are bad

Probably won't get to this until RC1.  (I can't imagine a world in which we'd block 1.8.0.15 on such a fix, to be honest, but I'll let those drivers sort it out.)

Comment 2

[Bob Clary [:bc:]]

Attachment: js1_5/extensions/regress-422592.js

for check in when the bug is fixed.

Comment 3

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Comment on attachment 309048 [details] [diff] [review]
uncatchable errors are bad

r=shaver

Comment 4

[Bob Clary [:bc:]]

/cvsroot/mozilla/js/tests/public-failures.txt,v  <--  public-failures.txt
new revision: 1.76; previous revision: 1.75

/cvsroot/mozilla/js/tests/js1_5/extensions/regress-422592.js,v  <--  regress-422592.js
initial revision: 1.1

changeset:   15654:397a1c47022e

Comment 5

[Stefan [:stefanh]]

Is this fixed now?

Comment 6

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Attachment: Updated to tip

Comment 7

[Blake Kaplan (:mrbkap) (inactive, use needinfo)]

Pushed as changeset 306d738a3e40.

Comment 8

[Brendan Eich [:brendan]]

Comment on attachment 329434 [details] [diff] [review]
Updated to tip

>+MSG_DEF(JSSMSG_SCRIPTS_ONLY,             7, 0, JSEXN_NONE, "only works on JS scripts") 
>+MSG_DEF(JSSMSG_CANT_DISASSEMBLE,         8, 0, JSEXN_NONE, "Could not disassemble script")

"works only", not "only works"

"JS scripts" should just be scripts, like the second addition -- unless you mean works only on Script objects, in which case say that. r=me ahead of the patch.

/be