Closed
Bug 422592
Opened 13 years ago
Closed 13 years ago
js.c dis/dissrc kill script execution
Categories
(Core :: JavaScript Engine, defect)
Tracking
()
RESOLVED
FIXED
People
(Reporter: timeless, Assigned: timeless)
References
Details
Attachments
(2 files, 1 obsolete file)
3.06 KB,
text/plain
|
Details | |
2.72 KB,
patch
|
mrbkap
:
review+
|
Details | Diff | Splinter Review |
I was hoping to do either: dis(print);1 or try{dissrc(print);} catch (e){};1 but neither work. (this can be tested in js shell and jsdb, but not xpcshell)
Comment on attachment 309048 [details] [diff] [review] uncatchable errors are bad Probably won't get to this until RC1. (I can't imagine a world in which we'd block 1.8.0.15 on such a fix, to be honest, but I'll let those drivers sort it out.)
Comment 2•13 years ago
|
||
for check in when the bug is fixed.
Updated•13 years ago
|
OS: Windows XP → All
Attachment #309048 -
Flags: review?(mrbkap)
Comment on attachment 309048 [details] [diff] [review] uncatchable errors are bad r=shaver
Attachment #309048 -
Flags: review?(shaver)
Attachment #309048 -
Flags: review?(mrbkap)
Attachment #309048 -
Flags: review+
Comment 4•13 years ago
|
||
/cvsroot/mozilla/js/tests/public-failures.txt,v <-- public-failures.txt new revision: 1.76; previous revision: 1.75 /cvsroot/mozilla/js/tests/js1_5/extensions/regress-422592.js,v <-- regress-422592.js initial revision: 1.1 changeset: 15654:397a1c47022e
Comment 5•13 years ago
|
||
Is this fixed now?
Comment 6•13 years ago
|
||
Attachment #309048 -
Attachment is obsolete: true
Attachment #329434 -
Flags: review+
Comment 7•13 years ago
|
||
Pushed as changeset 306d738a3e40.
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Comment 8•13 years ago
|
||
Comment on attachment 329434 [details] [diff] [review] Updated to tip >+MSG_DEF(JSSMSG_SCRIPTS_ONLY, 7, 0, JSEXN_NONE, "only works on JS scripts") >+MSG_DEF(JSSMSG_CANT_DISASSEMBLE, 8, 0, JSEXN_NONE, "Could not disassemble script") "works only", not "only works" "JS scripts" should just be scripts, like the second addition -- unless you mean works only on Script objects, in which case say that. r=me ahead of the patch. /be
Updated•13 years ago
|
Flags: in-testsuite? → in-testsuite+
You need to log in
before you can comment on or make changes to this bug.
Description
•