422645 - links in the history menu are not working

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

seen on Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031302 Minefield/3.0b5pre

all popups are working fine, aparte the extend bug in the history menu that should be fixed in the next build, if i click on an history item nothing happens, it's not visited, the onCommand is not fired.

need to find the regression window

Comment 1

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

if i'm not wrong this could be a regression from Bug 409748, if i put back the statustext attribute to the menuitems, the menu works again

Comment 2

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

reg window:
http://bonsai.mozilla.org/cvsquery.cgi?module=PhoenixTinderbox&date=explicit&mindate=1205298240&maxdate=1205324099

Comment 3

[Alex]

I can confirm on WinXP
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031304 Minefield/3.0b5pre

What's worse is that clicking on a history link replicates the list.  Perform the bug 5 or 6 times to really see the problem.

Comment 4

[Alex]

Attachment: History Replication

The history is replicated by this bug.

Comment 5

[Brian Polidoro]

That bug is what Marco referred to in the first comment:
>the extend bug in the history menu that should be fixed in the next build

So those are two separate issues.  

Comment 6

[Asa Dotzler [:asa]]

This is All/All and major. 

Comment 7

[Marco Bonardo [:mak] (Away Apr 25 - May 5)]

(In reply to comment #5)
> >the extend bug in the history menu that should be fixed in the next build
> 
> So those are two separate issues.  

exactly, that is bug 422528, these bugs are due to different things, even if they became visible in the same build.

Comment 8

[Asaf Romano (gone)]

Attachment: patch

Comment 9

[Asaf Romano (gone)]

mozilla/browser/base/content/browser-menubar.inc 1.152

Comment 11

[Tracy Walker [:tracy]]

verified with: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031704 Minefield/3.0b5pre and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031704 Minefield/3.0b5pre

Comment 13

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv