Closed Bug 422723 Opened 12 years ago Closed 11 years ago

Thunderbird Preferences/Certificates tab buttons wrap strangely

Categories

(Thunderbird :: Preferences, defect, P3)

defect

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 3.0b1

People

(Reporter: bob.lord, Assigned: philor)

Details

Attachments

(1 file)

version 3.0a1pre (2008031303)

In the "Thunderbird Preferences" window, on the Advanced button, on the Certificates tab, there are 4 buttons.  The first 3 buttons show up on one line, and the 4th shows up on a different line.  

I think they are supposed to be on the same line.
They only wrap because the labels are longer than what will fit on one line in the default size - on platforms that allow resizing the pref dialog, you can just widen it bigger than any other tab or pane needs, and get them on one line.

Since the prettiness win doesn't trump the benefit of familiar labels we get by having them the same as Fx, and Fx isn't likely to be changing strings at this point, about all we could do is to decide that (for every locale, whether they need it or not or need it to not be) we'd rather force 2x2 (or even 4x1) always, instead for whatever happens to fit.

(Unless, of course, "Validation" is just enough smaller than "Verification" for your default font, in which case once we pick up Fx's change for that button label, you'll be set.)
Though perhaps we could skip the 23px of class="indent" and use more vertical separation from the description, instead.

Or make the pane less alien and more like the rest of the prefs, with <label flex="1"> <button>, but that would require someone managing to write six to eight word descriptions of things like CRLs and "Security Devices."
And in fact, the indent got in my way in bug 431819, so I'm sort of accidentally fixing this there.
Assignee: nobody → philringnalda
Depends on: 431819
Or, not.
Status: NEW → ASSIGNED
No longer depends on: 431819
Priority: -- → P3
OS: Linux → All
Hardware: PC → All
Attached patch Fix v.1Splinter Review
It's only really pretty on OS X, but there's not a lot of pretty that can be managed for a panel with nothing but four buttons, and it at least gets rid of the "here's a label that repeats the text of the buttons below it."
Attachment #343854 - Flags: ui-review?(clarkbw)
Comment on attachment 343854 [details] [diff] [review]
Fix v.1

this looks like a good step forward. The label is pretty useless and I'd rather see the layout improved. Next we should start thinking of an overall better presentation for this page
Attachment #343854 - Flags: ui-review?(clarkbw) → ui-review+
Attachment #343854 - Flags: review?(mkmelin+mozilla)
Comment on attachment 343854 [details] [diff] [review]
Fix v.1

Yup. One step in the right direction. r=mkmelin
Attachment #343854 - Flags: review?(mkmelin+mozilla) → review+
http://hg.mozilla.org/comm-central/rev/4a54199d5630
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 3.0b1
You need to log in before you can comment on or make changes to this bug.