Closed Bug 422763 Opened 16 years ago Closed 15 years ago

wrong icon for "close" button in "about {addon}" dialog

Categories

(Toolkit :: Add-ons Manager, defect)

Product:
Toolkit
Component:
Add-ons Manager
Version:
1.9.0 Branch
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
trivial

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla1.9.2a1

People

(Reporter: u294409, Assigned: dao)

Details

(Keywords: polish, verified1.9.1, Whiteboard: [polish-easy][polish-visual][polish-p2])

Attachments

(3 files)

screenshot
176.92 KB, image/png
Details
with build 20090126
41.83 KB, image/png
Details
patch
1.08 KB, patch
mossop
: review+
beltzner
: approval1.9.1+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b5pre) Gecko/2008031304 Fedora/8 (Werewolf) Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; pl; rv:1.9b5pre) Gecko/2008031304 Fedora/8 (Werewolf) Minefield/3.0b5pre

wrong icons for "close" button

Reproducible: Always

Steps to Reproduce:
1. open addons manager
2. open context menu of some addon
3. select "about"
Actual Results:  
wrong icon for "close" button

Expected Results:  
gtk-close for "close" button
Attached image screenshot — 
Product: Firefox → Toolkit
Component: Add-ons Manager → Themes
QA Contact: extension.manager → themes

    
    

    
  
Alex, is this still an issue or has it been already fixed?
Version: unspecified → 1.9.0 Branch

    
    

    
  

      
      
      
      

        Attached image
          
        with build 20090126
        — 
      

    


  
looks like it is still an issue

    
    

    
  
(In reply to comment #3)
> Created an attachment (id=358924) [details]
> with build 20090126
> 
> looks like it is still an issue

I believe Dao can help us here.
Status: UNCONFIRMED → NEW
Ever confirmed: true

    
  
Assignee: nobody → dao
Component: Themes → Add-ons Manager
QA Contact: themes → add-ons.manager

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch
        — 
          — Splinter Review
      

    


  

        Attachment #359023 -
        Flags: review?(dtownsend)

        Attachment #359023 -
        Flags: review?(dtownsend) → review+

    
  
Keywords: checkin-needed, 
          
            polish
Whiteboard: [polish-easy]

    
  

        Attachment #359023 -
        Flags: approval1.9.1?

    
  
Target Milestone: --- → mozilla1.9.2a1

    
    

    
  
http://hg.mozilla.org/mozilla-central/rev/1d18d830df74
Status: NEW → RESOLVED
Closed: 15 years ago
Keywords: checkin-needed
Resolution: --- → FIXED

        Attachment #359023 -
        Flags: approval1.9.1? → approval1.9.1+

    
  
Keywords: checkin-needed

    
    

    
  
Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b4) Gecko/20090423 Firefox/3.5b4
and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090512 Minefield/3.6a1pre
Status: RESOLVED → VERIFIED
Keywords: fixed1.9.1 → verified1.9.1

    
    

    
  
This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

Dialog is a secondary interface, the icon problem is reasonably obvious.
Whiteboard: [polish-easy] → [polish-easy][polish-visual][polish-p2]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: