Install element uses variable in _()

RESOLVED FIXED

Status

addons.mozilla.org Graveyard
Public Pages
RESOLVED FIXED
10 years ago
2 years ago

People

(Reporter: clouserw, Unassigned)

Tracking

Details

(Reporter)

Description

10 years ago
In views/elements/install.thtml there are a few lines similar to:

sprintf(_($buttonMessage),$_install_platform_string)

This isn't going to work because $buttonMessage is a variable and needs to be a string so gettext can pick it up.  It's working right now because the string a_install is left over from a while ago, but gettext is trying to deprecate it now because it's not used anywhere that it can see.

Comment 1

10 years ago
Good catch. If we need to assign gettext strings to a variable, we should always keep intact the _('some_static_text') pattern because the gettext tools read the code files statically.

Comment 2

10 years ago
This is fixed since r11552.
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Assignee)

Updated

2 years ago
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.