Improve XHR cycle collection

RESOLVED FIXED

Status

()

Core
DOM
P2
normal
RESOLVED FIXED
10 years ago
9 years ago

People

(Reporter: Robert Sayre, Assigned: Robert Sayre)

Tracking

Trunk
Points:
---
Bug Flags:
wanted1.9.1 +

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [missed 1.9 checkin])

Attachments

(2 attachments)

(Assignee)

Description

10 years ago
We can do better on this!
(Assignee)

Comment 1

10 years ago
Created attachment 309322 [details] [diff] [review]
collect mDocument and progress events

I left the cross-site channel because we're going to take that out iirc.
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #309322 - Flags: superreview?(jonas)
Attachment #309322 - Flags: review?(jonas)
Comment on attachment 309322 [details] [diff] [review]
collect mDocument and progress events

Did you check that all current code is ok with mDocument being null?

r/sr=me if so
Attachment #309322 - Flags: superreview?(jonas)
Attachment #309322 - Flags: superreview+
Attachment #309322 - Flags: review?(jonas)
Attachment #309322 - Flags: review+
(Assignee)

Comment 3

10 years ago
(In reply to comment #2)
> (From update of attachment 309322 [details] [diff] [review])
> Did you check that all current code is ok with mDocument being null?

It looks good to me. The code nulls out mDocument in other places, including abort().
(Assignee)

Updated

10 years ago
Attachment #309322 - Flags: approval1.9?

Comment 4

10 years ago
I'm curious what leaks this fixes.
(Assignee)

Comment 5

10 years ago
(In reply to comment #4)
> I'm curious what leaks this fixes.
> 

No known leaks. I'm chasing an XHR/responseXML leak, and I saw this and found it insufficient. Jonas agreed.
Comment on attachment 309322 [details] [diff] [review]
collect mDocument and progress events

a1.9+=damons
Attachment #309322 - Flags: approval1.9? → approval1.9+
It looks like this patch never landed.
Whiteboard: [missed 1.9 checkin]

Comment 8

10 years ago
Comment on attachment 309322 [details] [diff] [review]
collect mDocument and progress events

Removing approval since this patch was not landed before we closed for 1.9.
Attachment #309322 - Flags: approval1.9+
Flags: wanted1.9.1?
Flags: wanted1.9.0.x?
Version: unspecified → Trunk
This is ready to land, right?
Flags: wanted1.9.1?
Flags: wanted1.9.1+
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x+
Priority: -- → P2
Created attachment 345100 [details] [diff] [review]
updated to trunk

Progress events are already CC'd.
Added mACGetChannel so that both channels are CC'd.
Bug 459470 changed mDocument to mXMLResult.
Attachment #345100 - Flags: superreview?(jonas)
Attachment #345100 - Flags: review?(jonas)
Attachment #345100 - Flags: superreview?(jonas)
Attachment #345100 - Flags: superreview+
Attachment #345100 - Flags: review?(jonas)
Attachment #345100 - Flags: review+

Updated

9 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 9 years ago
Resolution: --- → FIXED
Flags: wanted1.9.0.x+
You need to log in before you can comment on or make changes to this bug.