Closed Bug 422856 Opened 12 years ago Closed 11 years ago

Improve XHR cycle collection

Categories

(Core :: DOM: Core & HTML, defect, P2)

defect

Tracking

()

RESOLVED FIXED

People

(Reporter: sayrer, Assigned: sayrer)

Details

(Whiteboard: [missed 1.9 checkin])

Attachments

(2 files)

We can do better on this!
I left the cross-site channel because we're going to take that out iirc.
Assignee: nobody → sayrer
Status: NEW → ASSIGNED
Attachment #309322 - Flags: superreview?(jonas)
Attachment #309322 - Flags: review?(jonas)
Comment on attachment 309322 [details] [diff] [review]
collect mDocument and progress events

Did you check that all current code is ok with mDocument being null?

r/sr=me if so
Attachment #309322 - Flags: superreview?(jonas)
Attachment #309322 - Flags: superreview+
Attachment #309322 - Flags: review?(jonas)
Attachment #309322 - Flags: review+
(In reply to comment #2)
> (From update of attachment 309322 [details] [diff] [review])
> Did you check that all current code is ok with mDocument being null?

It looks good to me. The code nulls out mDocument in other places, including abort().
Attachment #309322 - Flags: approval1.9?
I'm curious what leaks this fixes.
(In reply to comment #4)
> I'm curious what leaks this fixes.
> 

No known leaks. I'm chasing an XHR/responseXML leak, and I saw this and found it insufficient. Jonas agreed.
Comment on attachment 309322 [details] [diff] [review]
collect mDocument and progress events

a1.9+=damons
Attachment #309322 - Flags: approval1.9? → approval1.9+
It looks like this patch never landed.
Whiteboard: [missed 1.9 checkin]
Comment on attachment 309322 [details] [diff] [review]
collect mDocument and progress events

Removing approval since this patch was not landed before we closed for 1.9.
Attachment #309322 - Flags: approval1.9+
Flags: wanted1.9.1?
Flags: wanted1.9.0.x?
Version: unspecified → Trunk
This is ready to land, right?
Flags: wanted1.9.1?
Flags: wanted1.9.1+
Flags: wanted1.9.0.x?
Flags: wanted1.9.0.x+
Priority: -- → P2
Attached patch updated to trunkSplinter Review
Progress events are already CC'd.
Added mACGetChannel so that both channels are CC'd.
Bug 459470 changed mDocument to mXMLResult.
Attachment #345100 - Flags: superreview?(jonas)
Attachment #345100 - Flags: review?(jonas)
Attachment #345100 - Flags: superreview?(jonas)
Attachment #345100 - Flags: superreview+
Attachment #345100 - Flags: review?(jonas)
Attachment #345100 - Flags: review+
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Flags: wanted1.9.0.x+
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.