Closed
Bug 422875
Opened 18 years ago
Closed 18 years ago
Editor feature tool is broken (javascript errors)
Categories
(addons.mozilla.org Graveyard :: Admin/Editor Tools, defect)
addons.mozilla.org Graveyard
Admin/Editor Tools
Tracking
(Not tracked)
VERIFIED
FIXED
3.2
People
(Reporter: clouserw, Assigned: rdoherty)
References
()
Details
Attachments
(1 file)
|
68.59 KB,
patch
|
morgamic
:
review+
|
Details | Diff | Splinter Review |
When trying to add a new feature:
Error: $("new-addon-id-" + tagid).parentNode is undefined
Source File: https://preview.addons.mozilla.org/js/editors.js
Line: 177
Updated•18 years ago
|
Assignee: nobody → rdoherty
| Assignee | ||
Comment 1•18 years ago
|
||
Status: NEW → ASSIGNED
| Assignee | ||
Comment 2•18 years ago
|
||
Additional info:
Remove scriptaculous references, use jquery because it is the new hotness.
| Assignee | ||
Comment 3•18 years ago
|
||
Updates to editor to use jquery & work in IE.
Attachment #310784 -
Flags: review?(laura)
Updated•18 years ago
|
Attachment #310784 -
Attachment is patch: true
Attachment #310784 -
Attachment mime type: application/octet-stream → text/plain
Updated•18 years ago
|
Attachment #310784 -
Flags: review?(laura) → review?(morgamic)
Comment 4•18 years ago
|
||
Comment on attachment 310784 [details] [diff] [review]
Diffs for changing from scriptaculous to jquery
Works as expected, form submission works as well. Nice work Ryan.
Attachment #310784 -
Flags: review?(morgamic) → review+
| Assignee | ||
Comment 5•18 years ago
|
||
Fixed in r11442.
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Comment 6•18 years ago
|
||
Verified FIXED; removed "Flashgot" from the Download Management category, reloaded the page, then added it back:
https://preview.addons.mozilla.org/en-US/firefox/editors/featured
Status: RESOLVED → VERIFIED
Updated•10 years ago
|
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•