make -j2 -f client.mk profiledbuild fails

RESOLVED FIXED in mozilla1.9.2a1

Status

defect
RESOLVED FIXED
11 years ago
Last year

People

(Reporter: caillon, Assigned: mrbkap)

Tracking

({fixed1.9.1})

Trunk
mozilla1.9.2a1
x86
Linux
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Random failures such as the compiler doesn't work, linker doesn't work, cannot find libraries, etc.

make -j1 -f client.mk profiledbuild       works
make -j2 -f client.mk profiledbuild       fails
make -j2 -f client.mk build               works
We should just make client.mk specify .NOTPARALLEL. It's not intended to be used with -jN. It does pass MOZ_MAKE_FLAGS from mozconfig down to the sub-make, so you should use that to do parallel builds.
Posted patch Proposed fix (obsolete) — Splinter Review
Assignee: nobody → mrbkap
Status: NEW → ASSIGNED
Attachment #362944 - Flags: review?(ted.mielczarek)
Attachment #362944 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 362944 [details] [diff] [review]
Proposed fix

+# in paralle.

Missing an 'l' there.
Attachment #362944 - Attachment is obsolete: true
Attachment #362945 - Flags: review+
Comment on attachment 362945 [details] [diff] [review]
Updated
[Checkin: Comment 5 & 8]


http://hg.mozilla.org/mozilla-central/rev/356065cfe21b
Attachment #362945 - Attachment description: Updated → Updated [Checkin: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.2a1
Version: unspecified → Trunk
Attachment #362945 - Flags: approval1.9.1?
Comment on attachment 362945 [details] [diff] [review]
Updated
[Checkin: Comment 5 & 8]

This is a safe fix that makes building on 1.9.1 better.
Comment on attachment 362945 [details] [diff] [review]
Updated
[Checkin: Comment 5 & 8]

a191=beltzner
Attachment #362945 - Flags: approval1.9.1? → approval1.9.1+
Blocks: 543296
Attachment #362945 - Attachment description: Updated [Checkin: Comment 5] → Updated [Checkin: Comment 5 & 8]

Updated

Last year
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.