423033 - mochitest should ignore non-existent files

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

I've hit this annoyance a few times:

1) Start writing some tests
2) Decide to delete or change the name of one of the tests
3) Mochitest suddenly fail on launch with:

[Exception... "Component returned failure code: 0x80520012 (NS_ERROR_FILE_NOT_FOUND) [nsILocalFile.isDirectory]" nsresult: "0x80520012 (NS_ERROR_FILE_NOT_FOUND)" location: "JS frame :: /Users/dolske/ff/trunk1/mozilla/obj-ff/_tests/testing/mochitest/server.js :: list :: line 260" data: no]

The problem is because the directory iterator gives the old symlinks that point to files that no longer exists. We should check for existence and ignore non-existent files. [Alternatively, throw a more descriptive error that suggests clearing out the old links in $objdir.]

This patch fixed the problem when I hit it.

Comment 1

[Jeff Walden [:Waldo]]

Comment on attachment 309537 [details] [diff] [review]
Patch v.1

I can't help thinking there's something we could do here to avoid the problem entirely, but this will work well enough for now.

Comment 2

[Justin Dolske [:Dolske]]

Checking in testing/mochitest/server.js;
  new revision: 1.25; previous revision: 1.24