423035 - can't run single chrome/a11y test automatically

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Karsten Düsterloh]

Attachment: allow running single chrome/a11y tests

You can't run just a single chrome or a11y test X.

perl runtests.pl --chrome --test-path=XXX
perl runtests.pl --a11y --test-path=XXX

just lead to 

404 Not Found
/redirect.htmlXXX was not found. 
404 Not Found
/redirect-a11y.htmlXXX was not found. 

Obviously, the URI to use is malformed.

This patch does:
- fix the URI passed to chrome/a11y test harnesses
- evaluates the URL to run just that one patch
- cleans up some useless XUL

Comment 1

[Karsten Düsterloh]

> - evaluates the URL to run just that one patch

This should read:
- evaluates the URI to run just that one test

Comment 2

[Karsten Düsterloh]

Attachment: better fix which does not break logging

The last patch broke if you specified a --log-file.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 309784 [details] [diff] [review]
better fix which does not break logging

Please also update testing/mochitest/runtests.py.in; runtests.pl.in is slowly (contingent on tinderbox-side changes) being retired in favor of the more readable and modifiable Python version, and once the Firefox tinderboxen start using it I intend to remove it from the tree.  Note also that SeaMonkey itself already uses runtests.py on MozillaTest's nye tinderbox.

Comment 4

[Karsten Düsterloh]

Attachment: fix runtests.py.in also

Fixing the Python test run script.
Also I noticed that logging doesn't work at all for chrome tests (SimpleTests.js::parentRunner is null), but that should probably go into a different bug.

Comment 5

[Jeff Walden [:Waldo]]

Comment on attachment 309837 [details] [diff] [review]
fix runtests.py.in also

>Index: testing/mochitest/harness-overlay.xul

>+  <script type="application/javascript;version=1.7">
>+  <![CDATA[

Keep the CDATA at the end of the previous line, as before -- no need to change it.


>+    function LoadTests()

Keep this capitalization as it was before as well.


>     {
>+      var dir = document.documentElement.getAttribute('directory');

Run loadTests from onload, please, since you're interacting with a half-formed DOM at this point, even tho there's no reason this shouldn't be present by this point?


>+      // if we got passed a test path, just run that one
>+      if (("testPath" in params) && (params.testPath))

Ditch both pairs of unneeded parentheses here.


>+      {
>+        function runSingleTest(aURL)
>+        {
>+          window.location.href = aURL;
>+        }
>+        setTimeout(runSingleTest, 0, url + params.testPath);
>+      }
>     }

With the at-load change, I don't think this setTimeout is needed (not entirely sure why it was needed before, to be honest).

Comment 6

[Karsten Düsterloh]

Attachment: fix Waldo's comments

Fixed review comments, plus:
<Waldo> does it work if you replace those with direct calls to
        populate and hookup?
<Waldo>	thing is, those expect to run before onload
        otherwise they don't run
<Mnyromyr> Waldo: yes, calling them directly works
<Waldo> please switch to onload and do that, then?

Taking over r+.

Landed on trunk.

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #4)
> Also I noticed that logging doesn't work at all for chrome tests
> (SimpleTests.js::parentRunner is null)

I filed bug 499577.