423044 - random orange in test_prompt.html test

Status: RESOLVED FIXED

(Toolkit :: Password Manager, defect)

Description

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

We just had a cycle of random orange in toolkit/components/passwordmgr/test/test_prompt.html.  dolske previously disabled a similar test in that test due to unexplained orange.

I suspect this is because the test is timing sensitive; it's easy for it to get the dialog in various stages of loading by lowering the timeout.

I have a patch (coming shortly) to make this test poll for the dialog being fully loaded (I don't think we display it to the user until it's fully loaded) and not do anything until it is.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Attachment: patch

I think we should try this.

Comment 2

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

This passes for me on Mac, btw.

Comment 3

[Justin Dolske [:Dolske]]

Comment on attachment 309555 [details] [diff] [review]
patch

I'm not sure this will fix the test that had previously been disabled; but having the test try again is definitely a good idea, regardless.

Comment 4

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Checked in to trunk, 2008-03-14 17:11 -0700.  We'll see what happens...

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Seems to have stuck, including for the test previously disabled.

I also checked in a followup removal of one line (with dolske's verbal review)  -- the ok(true, ...) saying that the timer was called -- to make it so the test doesn't produce a timing-dependent number of passes.