423059 - When using top right button (Mac OS X), no dark line between browser content and titlebar (10.5.2)

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Raymie Humbert]

User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b4) Gecko/2008030317 Firefox/3.0b4

A cool Mac OS X feature allows one to hide the navigation bar in Firefox. It's a systemwide feature, but Firefox has one issue with it. The Proto theme forces Firefox to show no dark line between the titlebar and the content. Go to a site and use the top-right button. There is no dark line to separate the titlebar from the content.

Reproducible: Always

Steps to Reproduce:
1. Go to any website.
2. Use the top-right button (Mac OS X).
Actual Results:  
There was no boundary between the titlebar and the browser content.

Expected Results:  
There should have been a line between the titlebar and the content, like most Apple applications.

This may be an issue related to how Proto implements a Unified theme: by not separating the titlebar and navigation bar. iSafari Leopard was not Unified (for Firefox 2.0.0.x only), but probably worked with this feature because it had a line. Could this be a limitation in the UI department?

Comment 1

[Raymie Humbert]

What is DUPEME?

Comment 2

[Asa Dotzler [:asa]]

this actually looks correct to me with the changes in bug 423361.

dupeme means that someone believes this issue to already be reported and is asking additional triagers to dig up the original bug report. 

Comment 4

[Asa Dotzler [:asa]]

OK. this was indeed a problem until the changes at bug 423361

Comment 5

[Raymie Humbert]

I installed 0.14.1 and the problem was fixed. In fact, Mac users should be told to get the 0.14.1 Proto theme upon installation, I believe.

Comment 6

[Asa Dotzler [:asa]]

Let's not resolve this until the patches land, in case the patch changes to not fix this issue. 

Raymie, mac users will get all of this and more when they install Firefox. The proto theme is just a demonstration of what's about to be done to the default Firefox theme. 

Comment 7

[Asa Dotzler [:asa]]

OK. this looks like it's quite fixed. tested with a tinderbox build from this evening on Mac OS X 10.5