423060 - Feed Handling in Google/Yahoo/Bloglines broken

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect, P2)

Description

[Jaime Mitchell (use [e-mail] for email)]

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031405 Minefield/3.0b5pre ID:2008031405

STR:
1. New Profile
2. Go to a site with a feed such as http://news.bbc.co.uk
3. Click the RSS icon in the location bar
4. Select Google as the handler and use this as from now on/as default
5. Subscribe in google reader
6. Now go to another site with a feed such as http://www.theregister.co.uk
7. Select RSS icon

Result:
The site appears to refresh, nothing else seems to happen. No errors in the error console.

Expected:
Displays the google page which choice of subscribe in google reader or google home page

This is a reasonably recent regression, I will try and find the range over the weekend.

Comment 1

[Marcia Knous [:marcia]]

Changing to all, I see this on Mac using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031404 Minefield/3.0b5pre as well as the Win XP nightly.

Comment 3

[Marcia Knous [:marcia]]

Regression window:  Works: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031104 Minefield/3.0b5pre

Broken: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031204 Minefield/3.0b5pre

Bug 381357 was the only bug I can see checked in related to RSS.

Comment 4

[Marcia Knous [:marcia]]

https://litmus.mozilla.org/show_test.cgi?id=4304 has been added to Litmus.

Comment 5

[Phil Ringnalda (:philor)]

Yeah, I wanted to blame sayrer, too, but backing bug 381357 out doesn't solve the
problem. Given the heinous things we do to channels and principals, now I'm
wondering about bug 415324.

Comment 6

[Phil Ringnalda (:philor)]

Paging Mr. Sayre, Mr. Sayre to the Regression Penalty Box, please.

Dunno how I could have failed to back out such a simple patch, but I apparently did fail, since from the http://hourly-archive.localgho.st/ Windows builds, the first build with the problem is 20080311 14:05, and http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1205269500.1205274891.30404.gz&fulltext=1 says the changes that picked up included an OS2 readme change and bug 381357, so I'm back to betting on it.

Comment 7

[Robert Sayre]

Attachment: fix

Comment 8

[Jaime Mitchell (use [e-mail] for email)]

This should be release noted for Beta 5.

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Rob: who should review this? Looks pretty small and simple, perhaps worth sneaking into B5 instead of relnote-ing.

Comment 10

[Robert Sayre]

(In reply to comment #9)
> Rob: who should review this? Looks pretty small and simple, perhaps worth
> sneaking into B5 instead of relnote-ing.
> 

Anyone can review it once I finish the test.

Comment 11

[Tony Chung [:tchung]]

hi rob, how close are you to completing the test?  i'd like to nom this for blocking beta 5 if you can get it done soon, and up for review.

Comment 13

[Robert Sayre]

Attachment: fix + test

Comment 14

[Marcia Knous [:marcia]]

verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040104 Minefield/3.0pre as well as the nightly XP build. I verified using the STR in Comment 0.