Feed Handling in Google/Yahoo/Bloglines broken

VERIFIED FIXED in Firefox 3

Status

P2
normal
VERIFIED FIXED
11 years ago
2 months ago

People

(Reporter: jaime.bugzilla, Assigned: sayrer)

Tracking

({regression, relnote})

Trunk
Firefox 3
regression, relnote
Dependency tree / graph
Bug Flags:
blocking-firefox3 +
in-litmus +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008031405 Minefield/3.0b5pre ID:2008031405

STR:
1. New Profile
2. Go to a site with a feed such as http://news.bbc.co.uk
3. Click the RSS icon in the location bar
4. Select Google as the handler and use this as from now on/as default
5. Subscribe in google reader
6. Now go to another site with a feed such as http://www.theregister.co.uk
7. Select RSS icon

Result:
The site appears to refresh, nothing else seems to happen. No errors in the error console.

Expected:
Displays the google page which choice of subscribe in google reader or google home page

This is a reasonably recent regression, I will try and find the range over the weekend.
Flags: blocking-firefox3?
Changing to all, I see this on Mac using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031404 Minefield/3.0b5pre as well as the Win XP nightly.
Keywords: regression
OS: Windows Vista → All
Hardware: PC → All
Duplicate of this bug: 423230
Flags: in-litmus?
Assignee: nobody → dolske
Flags: blocking-firefox3? → blocking-firefox3+
Priority: -- → P2
Regression window:  Works: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031104 Minefield/3.0b5pre

Broken: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031204 Minefield/3.0b5pre

Bug 381357 was the only bug I can see checked in related to RSS.
https://litmus.mozilla.org/show_test.cgi?id=4304 has been added to Litmus.
Flags: in-litmus? → in-litmus+
Yeah, I wanted to blame sayrer, too, but backing bug 381357 out doesn't solve the
problem. Given the heinous things we do to channels and principals, now I'm
wondering about bug 415324.
Paging Mr. Sayre, Mr. Sayre to the Regression Penalty Box, please.

Dunno how I could have failed to back out such a simple patch, but I apparently did fail, since from the http://hourly-archive.localgho.st/ Windows builds, the first build with the problem is 20080311 14:05, and http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1205269500.1205274891.30404.gz&fulltext=1 says the changes that picked up included an OS2 readme change and bug 381357, so I'm back to betting on it.
Blocks: 381357
(Assignee)

Updated

11 years ago
Assignee: dolske → sayrer
(Assignee)

Comment 7

11 years ago
Created attachment 310875 [details] [diff] [review]
fix
(Assignee)

Updated

11 years ago
Attachment #310875 - Attachment is patch: true
Attachment #310875 - Attachment mime type: application/octet-stream → text/plain
This should be release noted for Beta 5.
Keywords: relnote
Rob: who should review this? Looks pretty small and simple, perhaps worth sneaking into B5 instead of relnote-ing.
(Assignee)

Comment 10

11 years ago
(In reply to comment #9)
> Rob: who should review this? Looks pretty small and simple, perhaps worth
> sneaking into B5 instead of relnote-ing.
> 

Anyone can review it once I finish the test.
hi rob, how close are you to completing the test?  i'd like to nom this for blocking beta 5 if you can get it done soon, and up for review.
Duplicate of this bug: 425180
Whiteboard: [needs status update]
(Assignee)

Comment 13

11 years ago
Created attachment 312807 [details] [diff] [review]
fix + test
Attachment #312807 - Flags: review?(gavin.sharp)
Attachment #312807 - Flags: review?(gavin.sharp) → review+
(Assignee)

Updated

11 years ago
Whiteboard: [needs status update]
(Assignee)

Updated

11 years ago
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
verified fixed using  Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9pre) Gecko/2008040104 Minefield/3.0pre as well as the nightly XP build. I verified using the STR in Comment 0.
Status: RESOLVED → VERIFIED
Target Milestone: --- → Firefox 3

Updated

10 years ago
Blocks: 469593
Duplicate of this bug: 432205

Updated

2 months ago
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.