423085 - [Bookmark] restore from JSON, Japanese is garbled

Status: VERIFIED FIXED

(Firefox :: Bookmarks & History, defect, P1)

Description

[pal-moz]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031415 Minefield/3.0b5pre ID:2008031415


original, http://img170.imageshack.us/img170/5185/a1if1.jpg

after restore, http://img228.imageshack.us/img228/5641/a2kz7.jpg

Comment 1

[Takeshi Kurosawa :takenspc]

Attachment: Patch v1

|unescape|-ing |encodeURIComponent|-ed string is wrong. We should use |decodeURIComponent|.

Comment 2

[Takeshi Kurosawa :takenspc]

Attachment: Patch v2

Previous patch breaks backward compatibility for backup files today's build generated. This patch adds backward compatibility.

# |decodeURIComponent|-ing |encodeURIComponent|-ed string is doing nothing, make it simple :-).

Comment 3

[Takeshi Kurosawa :takenspc]

Attachment: Patch v2

Oops! Wrong file was uploaded!

Comment 4

[Asaf Romano (gone)]

Comment on attachment 309610 [details] [diff] [review]
Patch v2

I prefer breaking compat. rather than extending the file size that much, it's trunk!

Comment 5

[Takeshi Kurosawa :takenspc]

Attachment: Patch v3

OK. Simply pass the string.

Comment 6

[Asaf Romano (gone)]

mozilla/toolkit/components/places/src/utils.js 1.6

Comment 7

[pal-moz]

Attachment: screenshot

20080317_0038_firefox-3.0b5pre.en-US.win32.zip

not fixed.

Comment 8

[pal-moz]

sorry, fixed.

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031705 Minefield/3.0b5pre

1) delete old backup file
2) start/exit minefield
3) new backup file is created

(create new profile)

4) launch Minefield
5) open Library, Import and Backup >> Restore
6) choose above new backup file

maybe something wrong with old backup file.

Comment 9

[Tracy Walker [:tracy]]

verified with: 
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre)
Gecko/2008032106 Minefield/3.0b5pre
and
Mozilla/5.0 (Macintosh; U; PPC Mac OS X 10.4; en-US; rv:1.9b5pre)
Gecko/2008032104 Minefield/3.0b5pre

Comment 10

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv