423115 - OS/2 build break about GCC parameters in libpixman

Status: RESOLVED FIXED

(Core Graveyard :: GFX, defect)

Description

[Peter Weilbacher]

Attachment: remove --params from CFLAGS for OS/2

As William Hartzell posted in mozilla.dev.ports.os2 the changes to the libpixman Makefile.in broke compilation on OS/2. Not sure when those *-growth parameters were added to GCC but our 3.3.5 apparently doesn't understand them. Not sure if it is even easily possible to test for GCC versions in the Makefile, if not the attached patch gets us going again at least.

gcc -o pixman-mmx.o -c  -DUSE_MMX -DMOZILLA_INTERNAL_API
-DOSTYPE=\"OS22.45\" -DOSARCH=OS2 -IX:/mozilla/gfx/cairo/libpixman/src
-IX:/mozilla/gfx/cairo/libpixman/src/../../cairo/src
-IX:/mozilla/gfx/cairo/libpixman/src -I.  -I../../../../dist/include
-I../../../../dist/include/libpixman -I../../../../dist/include/nspr
 -I../../../../dist/sdk/include      -Wall -W -Wno-unused
-Wpointer-arith -Wcast-align -Wno-long-long -pedantic
-fno-strict-aliasing -Zomf -pipe  -DNDEBUG -DTRIMMED -O2
-DPACKAGE="mozpixman" -D_USE_MATH_DEFINES   -include
../../../../mozilla-config.h -DMOZILLA_CLIENT -Uunix -U__unix -U__unix__
 -mmmx -msse -Winline --param inline-unit-growth=10000 --param
large-function-growth=10000 X:/mozilla/gfx/cairo/libpixman/src/pixman-mmx.c
cc1.exe: error: invalid parameter `inline-unit-growth'
cc1.exe: error: invalid parameter `large-function-growth'

Comment 1

[Peter Weilbacher]

Fix checked into trunk. As this was about a build break and only OS/2 is affected I didn't want to wait for a1.9.