Closed Bug 423124 Opened 16 years ago Closed 16 years ago

CMD/CTRL+clicking a bookmark creates two new tabs

Categories

(Firefox :: Bookmarks & History, defect, P1)

defect

Tracking

()

VERIFIED FIXED
Firefox 3 beta5

People

(Reporter: jruderman, Assigned: mak)

References

Details

(Keywords: dogfood, qawanted, regression)

Attachments

(1 file)

Steps to reproduce:
1. Cmd+click a bookmark on the bookmarks toolbar.

Result: Two tabs open (both showing the bookmarked page).

Expected: Only one new tab should open (showing the bookmarked page).

Tested using a Mac trunk debug build updated about an hour ago.
Flags: blocking1.9?
Also reported on Linux (bug 423210).

Is everyone seeing this bug or just us?
I see this bug, using:
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031611 Minefield/3.0b5pre
(In reply to comment #1)
> Also reported on Linux (bug 423210).
> 
> Is everyone seeing this bug or just us?
> 

I also see this with

Mozilla/5.0 (Windows; U; Windows NT 5.1; da; rv:1.9b5pre) Gecko/2008031605 Minefield/3.0b5pre
OS: Mac OS X → All
Hardware: PC → All
Suspect this is more likely to be a Places regression
Component: General → Places
Flags: blocking1.9?
Keywords: qawanted
Product: Core → Firefox
QA Contact: general → places
Assignee: nobody → mak77
Flags: blocking-firefox3+
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta5
Summary: Cmd+clicking a bookmark on the toolbar creates two new tabs → CMD/CTRL+clicking a bookmark creates two new tabs
Attached patch patchSplinter Review
fixes double openings on menus, don't hide open tabs confirm dialog, fixed new bookmarks toolbar menu onpopupshowing handler (was throwing since we were calling handler for the main bookmarks menu view too)
Attachment #309926 - Flags: review?(mano)
Comment on attachment 309926 [details] [diff] [review]
patch

r=mano
Attachment #309926 - Flags: review?(mano) → review+
mozilla/browser/base/content/browser-menubar.inc 1.155
mozilla/browser/base/content/browser-places.js1.122
mozilla/browser/components/places/content/menu.xml 1.124
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
It seems ctrl-clicking from bookmarks menu have been fixed along with ctrl-clicking of bookmarks on the toolbar. ctrl-clicking on livemark entries still gives 2 tabs.

This is only tested on linux.

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008031904 Minefield/3.0b5pre
DivineGod, can you reopen bug 423210 for that?
(In reply to comment #12)
> It seems ctrl-clicking from bookmarks menu have been fixed along with
> ctrl-clicking of bookmarks on the toolbar. ctrl-clicking on livemark entries
> still gives 2 tabs.

on win i cannot reproduce, i've tried in every position... where are those livemarks, in menu, in sidebar, on toolbars, everywhere?
Well, I tried just now, before considering reopening the bug, but now I can't reproduce the bug.

So I guess it is fixed.
verified with:
Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5) Gecko/2008032606 Firefox/3.0b5
and
Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-GB; rv:1.9b5) Gecko/2008032604 Firefox/3.0b5
Status: RESOLVED → VERIFIED
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: