Closed Bug 423138 Opened 16 years ago Closed 16 years ago

browser test crashes on 64bit linux

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Platform:
x86
Linux
Type:
defect
Priority:
Not set
Severity:
blocker

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: smaug, Assigned: smaug)

References

Details

Attachments

(2 files)

Stack
52.68 KB, text/plain
Details
possible patch
985 bytes, patch
brendan
: review+
beltzner
: approval1.9+
Details | Diff | Splinter Review
Attached file Stack — 
Currently ´perl runtests.pl -browser-chrome´ crashes on 64bit linux.
This is a regression from bug 421806.
Flags: blocking1.9?
Attached patch possible patch — — Splinter Review 
Before bug 421806 there was a cast to (ptrdiff_t). Putting it back fixes the 
crash.
Comment on attachment 309653 [details] [diff] [review]
possible patch

Is this the right thing to do? I know nothing about spidermonkey code.
Attachment #309653 - Flags: review?(igor)
Comment on attachment 309653 [details] [diff] [review]
possible patch

64-bit fix, restores lost cast, easy a+.

/be
Attachment #309653 - Flags: review+
Attachment #309653 - Flags: approval1.9?
Comment on attachment 309653 [details] [diff] [review]
possible patch

a1.9=beltzner
Attachment #309653 - Flags: review?(igor)
Attachment #309653 - Flags: approval1.9?
Attachment #309653 - Flags: approval1.9+
Assignee: general → Olli.Pettay
Landed: mozilla/js/src/jsopcode.c 	3.305
Status: NEW → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-
Flags: blocking1.9?
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: