423217 - Rating stars should not be transparent

Status: RESOLVED FIXED

(Firefox :: Theme, defect, P2)

Description

[Dave Townsend [:mossop]]

The rating stars in the get add-ons section of the add-ons manager are currently blue for a filled in star, and a blue outline with a somewhat transparent fill.

This is something of a problem because the colour of a selected list item is blue, so it looks like any selected item is rated 5.

Comment 1

[Mike Beltzner [:beltzner, not reading bugmail]]

Apparently this will be fixed with the next icon drop.

Comment 2

[Alex Faaborg [:faaborg] (Firefox UX)]

Attachment: New stars, still needs some work

Here are the stars.  Better, but still isn't working that well on luna silver.  We might try a purple star or something.  The issue isn't transparency as much as creating a clear distinction between active and inactive given the range of possible background colors.

Comment 3

[Mike Connor [:mconnor]]

I'd probably land these and resolve the blocker, and figure out Luna Silver if we have time to do so.  Otherwise we're done, IMO.

Comment 4

[Dave Townsend [:mossop]]

These still look like they will be almost indistinguishable on a white background, which is what the unselected background is essentially everywhere as I recall?

Comment 5

[Alex Faaborg [:faaborg] (Firefox UX)]

Yeah, we still need to fix this.  Icon revisions aren't on any developers critical path, since I'm managing feedback with the Iconfactory and generating the set of files to land is now automated.   There is no need for us to start preemptively resolving bugs that still need to be actually addressed.

Comment 6

[Mike Connor [:mconnor]]

Who said anything about preemptively resolving?  From the comments I assumed these were ok.  So what's the ETA on resolution here?

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

>From the comments I assumed these were ok.

Sorry, several of us had realized that these were still broken, but that was out of band of the sequence of comments.  Mossop notes the problem in comment #4.

This isn't the highest priority icon change right now, but we should have it resolved in one of the drops before RC1 on Tuesday.

Comment 9

[Alex Faaborg [:faaborg] (Firefox UX)]

>[eta on icons?]

new icons should land in 24 to 48 hours.

Comment 10

[Mike Connor [:mconnor]]

faaborg, its been 120 hours, status?

Comment 11

[Alex Faaborg [:faaborg] (Firefox UX)]

The icons were included in the set of chopped up files which is why they didn't make the last drop.  I'm landing them now.

Comment 12

[Alex Faaborg [:faaborg] (Firefox UX)]

sorry, were/were not

Comment 13

[Mike Beltzner [:beltzner, not reading bugmail]]

This is now fixed, new icons landed with the latest windows drop.