423382 - float("Inf") in runtests.py doesn't work

Status: RESOLVED FIXED

(Testing :: Mochitest, defect, P1)

Description

[:Gavin Sharp [email: [e-mail]]]

I:\moz\mozilla>python ff-opt/_tests/testing/mochitest/runtests.py
Traceback (most recent call last):
  File "ff-opt/_tests/testing/mochitest/runtests.py", line 419, in <module>
  File "ff-opt/_tests/testing/mochitest/runtests.py", line 194, in main
  File "ff-opt/_tests/testing/mochitest/runtests.py", line 115, in __init__
ValueError: invalid literal for float(): Inf


According to http://bugs.python.org/msg53199 , the fact that float("Inf") works at all is just a fluke, and is platform dependent. I'm using Python 2.5 on Windows.

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Attachment: patch

Comment 2

[Robert Sayre]

Comment on attachment 309878 [details] [diff] [review]
patch

whatever Jeff is happy with. I clearly don't know whether or which Infinity works.

Comment 3

[Jeff Walden [:Waldo]]

Comment on attachment 309878 [details] [diff] [review]
patch

The web claims None and () are bottom and top values for the reals in Python, but Python mailing list traffic says this might change, and it's a touch too cute for one-off use.

>+    defaults["leakThreshold"] = float(1e3000)

You don't need the float() call if you use a floating-point exponential; r=me with that change:

>>> 1.0e3000 
inf

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Landed with that change.

mozilla/testing/mochitest/runtests.py.in 	1.20

Comment 5

[Jeff Walden [:Waldo]]

Moving a bunch of Core :: Testing bugs to Testing :: Mochitest to clear out the former, which is obsolete now that we have more specialized categories for such bugs; filter on the string "MochitestMmMm" to delete all these notifications.