423391 - Link coloring wrong for history item which is also a bookmark

Status: RESOLVED FIXED

(Firefox :: Bookmarks & History, defect)

Description

[Hao Shen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; zh-CN; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

When I visit a website which has been saved to my bookmarks, it will be saved to history. Then this URL will be shown as visited URL in other websites. But I can not delete this history item. Even after deleting all history, this URL is shown as visited URL too. At this time, if I should open places.sqlite, the URL is there too. It will be shown as unvisited URL only when I delete places.sqlite file.

Reproducible: Always

Steps to Reproduce:
1.Save "www.mozilla.com" to bookmarks.
2.Visit "www.mozilla.com".
3.Create a local webpage include the hyperlink "www.mozilla.com".
4.Open the local webpage with Firefox3.0Beta4.
5.The "www.mozilla.com" will be shown as visited URL.
6.Press Ctrl+Shift+Del to delete all history.
7.Restart Firefox.
8.Open the local webpage again. You will see the URL "www.mozilla.com" is still shown as visited URL.
9.Close Firefox and delete places.sqlite file in your profile.
10.Launch Firefox and open the local webpage.You will see the URL is shown as unvisited URL.
Actual Results:  
The URL is shown as visited url.

Expected Results:  
The URL is shown as unvisited url.

Comment 1

[Simon Bünzli]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008031605
Confirming.

Comment 2

[Marco Bonardo [:mak]]

IIRC we are using visit_count on a moz_place to see if it's visited, so this could potentially be fixed by bug 416313, will check if that's true on my next iteration over there

Comment 3

[Marco Bonardo [:mak]]

Jin could you check if the moz_historyvisits table is empty after you do clear private data?

Comment 4

[Hao Shen]

Yes, it is empty after clearing.

Comment 5

[Marco Bonardo [:mak]]

so should be that, visit_count is not cleared on clear history for frecency calculation, bug 416313 will change that

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

This will not block the final release of Firefox 3.

Comment 7

[Marco Bonardo [:mak]]

should have been fixed by dependant bugs

now link coloring is not more based on visit_count, rather on the presence of a visit for the specified uri in moz_historyvisits table

Comment 8

[Gervase Markham [:gerv]]

Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv