423550 - Disable Current Version of Google Toolbar in FX3

Status: RESOLVED WONTFIX

(Toolkit :: Blocklist Policy Requests, defect)

Description

[Damon Sicore (:damons)]

See bug 422018 for details.

Comment 1

[Michael Morgan [:morgamic]]

Damon, are we moving ahead with this?

Comment 2

[Kev Needham [:kev]]

mfinkle is working with Google on completing their Fx3 compatible version for release. what's drop dead on this?

Comment 3

[Kev Needham [:kev]]

So, quick question on adding this to the blocklist. The current version of the Google toolbar is flagged as Fx2 compatible only. I was just wondering if extensions should be added to the blocklist if they're crashing the browser because end-users have explicitly overridden compatibility checking.

Comment 4

[timeless]

yes

Comment 5

[Michael Morgan [:morgamic]]

Hey, why would we blocklist this if it's caused by overriding compat checking?  I think this is WONTFIX or INVALID.

What is the nature of the crash?  Is it crashing on startup?

How does it match up with:
http://wiki.mozilla.org/Blocklisting

Comment 6

[Samuel Sidler (old account; do not CC)]

(In reply to comment #5)
> Hey, why would we blocklist this if it's caused by overriding compat checking? 
> I think this is WONTFIX or INVALID.

Because it's our topcrash in RC1 and has been a topcrash in a number of betas. Also, Google said we could (bug 422018 comment 17).

> What is the nature of the crash?  Is it crashing on startup?

It's crashing "randomly" during usage, not on startup.

> How does it match up with:
> http://wiki.mozilla.org/Blocklisting

Well, that didn't exist previously. Given that enough of our ~1m users have disabled compat checking to cause this to become our topcrash, I think we should make an exception to the policy and blocklist this extension. Google agrees.

Comment 7

[Basil Hashem [:baz]]

I'd like to get this resolved please. It meets our criteria of "major user facing issue".

Add-on: Google Toolbar 3.0.20070525M (can we do 3.*?)
Platform: Windows & Mac
Firefox Versions: 3.*

Reviewing http://crash-stats.mozilla.com/topcrasher/byversion/Firefox/3.0, I'm seeing both libraries for Win & Mac on the list.

Comment 8

[Basil Hashem [:baz]]

Tony, do you have time to test it this week. If so, Morgamic will get a patch. Thanks.

Comment 9

[Tony Chung [:tchung]]

sure, send the test attachment here in the bug.  i can hop on this after we get rc3 out the door.

Comment 10

[Michael Morgan [:morgamic]]

Unless we want to block 3.x for Linux, too, we need to fix bug 438287 first.

Comment 11

[Tony Chung [:tchung]]

im assuming this is blocking firefox 3 ship?   setting flag.

Comment 12

[Mike Beltzner [:beltzner, not reading bugmail]]

Is the current version set to be compatible, or are we doing this to prevent the people who've overridden compatibility checking?

Comment 13

[Kev Needham [:kev]]

The latter (which still makes me question why we're doing this, tbh, because what's the point of having compatibility checks if we're just going to override users overriding them?)

Comment 14

[Mike Beltzner [:beltzner, not reading bugmail]]

AIUI, we're doing it because enough people are crashing with this to make us believe that it's making Firefox 3 look unstable, despite the fact that it was users disabling the compatibility checks that lead to that instability.

The more I think about it, I tend to agree with Kev and Morgamic's earlier comments. If the add-on isn't labelled as compatible, we probably shouldn't be using the blocklist this way.

Not blocking, suggesting WONTFIX, especially since an update is about to become available.

Comment 15

[Tony Chung [:tchung]]

per comment #5 and comment #14, i'll resolve this wontfix.