423619 - Sunbird and Thunderbird pages shouldn't have links to "themes" page

Status: VERIFIED FIXED

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: "View All" link in Sunbird themes misses its type and category

1. Load https://preview.addons.mozilla.org/en-US/sunbird/browse/type:2
2. Click "See All"

Expected Results:

https://preview.addons.mozilla.org/en-US/sunbird/browse/type:2/cat:all?sort=name loads

Actual Results:

https://preview.addons.mozilla.org/en-US/sunbird/browse/type:/cat:?sort=name loads

Comment 1

[Stephen Donner [:stephend] Not actively reading bugmail]

Can we sneak this in to 3.21?

Comment 2

[Fred Wenzel [:wenzel]]

Hm. That's because themes are not a valid hybrid category for Sunbird (i.e. it's unlinked to an "appearance extension" category). This page should probably not even be linked to anywhere.

Comment 3

[Fred Wenzel [:wenzel]]

We decided on fixing this by removing the "I want to find..." list for Sunbird for now, because due to the small number of categories for Sunbird it doesn't provide much additional value there at the moment.

Comment 5

[Michael Morgan [:morgamic]]

Chris could you post a quick fix for these?

Comment 6

[Chris Pollett]

Attachment: removes the I am looking for element for Sunbird and Thunderbird as fwenzel suggested

The proposed patch would also fix Bug 423620

Comment 7

[Chris Pollett]

Thanks for the review clouserw!

Comment 8

[Stephen Donner [:stephend] Not actively reading bugmail]

Hrm; I checked on Khan, which should have the latest fixes, and still see the "I want to..." box:

http://img146.imageshack.us/my.php?image=picture6ve8.png

Why is this?

Comment 10

[Fred Wenzel [:wenzel]]

Attachment: Removing pitch from landing pages and globally from sidebar for Sb and Tb

Can you review again, Wil? This patch removes the "pitch" box globally from the sidebar (since it was still present on the recommended page also), and it removes it from the landing pages as well.

Comment 11

[Fred Wenzel [:wenzel]]

Thanks! Committed to r12123.

Comment 12

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using https://remora-reskin.stage.mozilla.com/en-US/sunbird/ and https://remora-reskin.stage.mozilla.com/en-US/thunderbird/, and their respective landing pages.