Summary: "View All" link in Sunbird themes misses its type and category 1. Load https://preview.addons.mozilla.org/en-US/sunbird/browse/type:2 2. Click "See All" Expected Results: https://preview.addons.mozilla.org/en-US/sunbird/browse/type:2/cat:all?sort=name loads Actual Results: https://preview.addons.mozilla.org/en-US/sunbird/browse/type:/cat:?sort=name loads
Can we sneak this in to 3.21?
Hm. That's because themes are not a valid hybrid category for Sunbird (i.e. it's unlinked to an "appearance extension" category). This page should probably not even be linked to anywhere.
We decided on fixing this by removing the "I want to find..." list for Sunbird for now, because due to the small number of categories for Sunbird it doesn't provide much additional value there at the moment.
Chris could you post a quick fix for these?
Created attachment 313766 [details] [diff] [review] removes the I am looking for element for Sunbird and Thunderbird as fwenzel suggested The proposed patch would also fix Bug 423620
Thanks for the review clouserw!
Hrm; I checked on Khan, which should have the latest fixes, and still see the "I want to..." box: http://img146.imageshack.us/my.php?image=picture6ve8.png Why is this?
Created attachment 314650 [details] [diff] [review] Removing pitch from landing pages and globally from sidebar for Sb and Tb Can you review again, Wil? This patch removes the "pitch" box globally from the sidebar (since it was still present on the recommended page also), and it removes it from the landing pages as well.
Thanks! Committed to r12123.
Verified FIXED using https://remora-reskin.stage.mozilla.com/en-US/sunbird/ and https://remora-reskin.stage.mozilla.com/en-US/thunderbird/, and their respective landing pages.