423621 - Grammar error in add-on installation dialog

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Francois Botha]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-GB; rv:1.9b4) Gecko/2008030714 Firefox/3.0b4

When installing a new add-on, I see this message:

"Only install add-ons from authors whom you trust."

Using "only" incorrectly is a very common mistake.

It should be:

"Install add-ons only from authors whom you trust."

The word "only" qualifies the authors and not the verb "install".

Reproducible: Always

Comment 1

[Francois Botha]

Attachment: Screenshot of add-on installation dialog

Comment 2

[Francois Botha]

What's happening on this task?  It's an obvious error and should be a quick-fix?  I really hate grammar errors.

Comment 3

[Dave Townsend [:mossop]]

It is a quick fix however was filed after the localisation freeze so could not make Firefox 3. It needed to wait for Firefox 3.1.

Comment 4

[Dave Townsend [:mossop]]

Attachment: updated screenshot

Madhava, do you concur with this change?

Comment 5

[Dave Townsend [:mossop]]

Attachment: patch

Comment 6

[Dave Townsend [:mossop]]

Landed in changeset abb9afa5c343

Comment 7

[Rimas Kudelis [use needinfo to ping]]

Dave: I don't think grammar errors like this can't land after string freeze. You haven't changed the meaning (at least the supposed meaning) of the string, so you don't really have to change its identifier, nor to expect localizers to do some changes in their files.

Comment 8

[Axel Hecht [:Pike]]

I agree that this could be landed on the branch without identifier change, I don't think that I agree that this shouldn't have no identifier change on trunk, though.

I'm not convinced that we don't have a localization that carried over that bug, I'd rather be safe than sorry on trunk.