Update to breakpad revision 250

RESOLVED FIXED

Status

()

Toolkit
Breakpad Integration
RESOLVED FIXED
9 years ago
9 years ago

People

(Reporter: ted, Assigned: ted)

Tracking

Trunk
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

9 years ago
Created attachment 310270 [details] [diff] [review]
update from revision 240 to 250

I'd like to get Alfred's Solaris fixes in for b5 so they can ship Firefox with Breakpad there. This patch contains a lot of stuff, but most of it is in the processor code, and thus not really relevant to us. There are a few things in the Windows handler code, due to the out of process minidump writing landing, I'm taking a look at those now, and I'll spin some try server builds with this patch to be sure.
(Assignee)

Updated

9 years ago
Assignee: nobody → ted.mielczarek
Flags: blocking1.9?

Updated

9 years ago
Blocks: 391361
Is there a changelog somewhere ?
(Assignee)

Comment 2

9 years ago
You can see the SVN revision log here:
http://code.google.com/p/google-breakpad/source/list
(Assignee)

Comment 3

9 years ago
Created attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes
Attachment #310270 - Attachment is obsolete: true
(Assignee)

Comment 4

9 years ago
Right, so, I decided not to import the windows client bits, to avoid any possible risk there. The only thing this patch touches that we actually build is src/google_breakpad/common/minidump_format.h, and that's just a refactoring of the contents of the file, no actual content changes.

Comment 5

9 years ago
Comment on attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes

rs=sayrer, mostly npotb
Attachment #310388 - Flags: review+
(Assignee)

Comment 6

9 years ago
Comment on attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes

This patch is almost entirely NPOTB, and the part that is part of the build is just splitting one large header into several smaller header files. It's a prerequisite for Solaris breakpad support.
Attachment #310388 - Flags: approval1.9?
Comment on attachment 310388 [details] [diff] [review]
update from r240 to r250, without the windows client changes

the sweet sound
of patch-set approval
comin' down in a 
not quite freeze

(a=shaver)
Attachment #310388 - Flags: approval1.9? → approval1.9+
(Assignee)

Comment 8

9 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 9 years ago
Flags: blocking1.9?
Resolution: --- → FIXED

Updated

9 years ago
Depends on: 424018

Updated

9 years ago
No longer depends on: 424018
You need to log in before you can comment on or make changes to this bug.