423696 - Value change events not fired for text inputs and editable combos

Status: RESOLVED FIXED

(Core :: Disability Access APIs, defect, P2)

Description

[Aaron Leventhal]

This came up while talking to a major screen reader vendor. They workaround they've been using for Firefox has broken other things, so they need us to fire the proper value change events when a text field changes.

Comment 1

[Aaron Leventhal]

Attachment: Fire value change for ROLE_ENTRY whenever contents change -- but remove duplicate events so it is fired only once

Comment 2

[Marco Zehe (:MarcoZ)]

I'm not Surkov, but I found this:

> void
> +nsDocAccessible::FireValueChangeForTextFields(nsIAccessible *aPossibleTextFieldAccessible)
> +{
> +  if (Role(aPossibleTextFieldAccessible) != nsIAccessibleRole::ROLE_ENTRY)

Better to add an NS_ENSURE_ARG_POINTER(aPossibleTextFieldAccessible); before the if statement?

Comment 3

[Aaron Leventhal]

Marco, I can add that but it's not a huge thing either way. The 2 consumers of that methods never pass null.

Comment 4

[Aaron Leventhal]

Try server builds that contain this and other fixes are arriving here:
https://build.mozilla.org/tryserver-builds/2008-03-18_12:[e-mail]-Fixes_423700_423696_423681_423570/

Comment 5

[alexander :surkov (:asurkov)]

Comment on attachment 310298 [details] [diff] [review]
Fire value change for ROLE_ENTRY whenever contents change -- but remove duplicate events so it is fired only once

r=me, the patch contains patch from bug 423698, be sure to check in separately

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

TM --> mozilla1.9, this won't block beta 5. If you disagree, please reset the TM to beta5 and explain why it needs to block beta.

Comment 7

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310298 [details] [diff] [review]
Fire value change for ROLE_ENTRY whenever contents change -- but remove duplicate events so it is fired only once

a1.9=beltzner

Comment 8

[alexander :surkov (:asurkov)]

Checking in accessible/src/base/nsDocAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.cpp,v  <--  nsDocAccessible.cpp
new revision: 1.238; previous revision: 1.237
done
Checking in accessible/src/base/nsDocAccessible.h;
/cvsroot/mozilla/accessible/src/base/nsDocAccessible.h,v  <--  nsDocAccessible.h
new revision: 1.79; previous revision: 1.78
done
Checking in accessible/src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <--  nsRootAccessible.cpp
new revision: 1.265; previous revision: 1.264
done

Comment 9

[Aaron Leventhal]

Surkov meant to mark this fixed.

Comment 10

[alexander :surkov (:asurkov)]

in-testsuite?

Comment 11

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381