New Folder has inconsistent name in Bookmark Contextual Dialog

VERIFIED FIXED in Firefox 3

Status

()

Firefox
Bookmarks & History
P1
normal
VERIFIED FIXED
10 years ago
7 years ago

People

(Reporter: Thomas Stache, Assigned: mano)

Tracking

Trunk
Firefox 3
Points:
---
Bug Flags:
blocking-firefox3 +
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Reporter)

Description

10 years ago
User-Agent:       Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031804 Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008031804 Firefox/2.0.0.12

When a new folder is created in the Bookmark Contextual Dialog, the custom folder name doesn't make it to the "quick select combobox"--it still shows "New Folder".

Reproducible: Always

Steps to Reproduce:
1. File a bookmark by clicking star icon, press star again to open dialog.
2. Expand folder configuration section.
3. Select a parent folder, press "New Folder" button to create a new folder.
4. Enter a custom name.
5. Select another folder from the list box, then select the new folder again.
Actual Results:  
Notice how the combobox above the listbox shows "New Folder" again.
(Bookmark is still filed in a folder with the custom name)

Expected Results:  
Custom folder name is displayed in the combobox.

Screenshot coming up.
(Reporter)

Comment 1

10 years ago
Created attachment 310361 [details]
Screenshot of issue

Contextual dialog with folder name discrepancy highlighted.
(Reporter)

Updated

10 years ago
Blocks: 394252
Version: unspecified → Trunk
Confirmed, I see this using Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031904 Minefield/3.0b5pre.
Status: UNCONFIRMED → NEW
Ever confirmed: true

Comment 3

10 years ago
Note: clicking "done" then returning via the star shows what you'd expect in the custom named folder.
(Reporter)

Updated

10 years ago
Flags: blocking-firefox3?
OS: Mac OS X → All
Hardware: PC → All
(Reporter)

Updated

10 years ago
Summary: New Folder has inconsistent name in Places Contextual Dialog → New Folder has inconsistent name in Bookmark Contextual Dialog
Flags: blocking-firefox3? → blocking-firefox3+
Assignee: nobody → mano
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → Firefox 3
Created attachment 313013 [details] [diff] [review]
patch
Attachment #313008 - Attachment is obsolete: true
Attachment #313013 - Flags: review?(dietrich)
Attachment #313008 - Flags: review?(dietrich)
Comment on attachment 313013 [details] [diff] [review]
patch

r=me
Attachment #313013 - Flags: review?(dietrich) → review+
mozilla/browser/components/places/content/editBookmarkOverlay.js 1.40
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Resolution: --- → FIXED
(Reporter)

Comment 8

10 years ago
Verified. The new folder is now listed with the correct custom name in both combobox and listbox.
Verified with Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041005 Minefield/3.0pre

I don't think that bugs with security minor could block a release. Raising severity to normal.
Severity: minor → normal
Status: RESOLVED → VERIFIED
Flags: in-litmus?
in-litmus-  this will basically be picked up in the add folder test case.
Flags: in-litmus? → in-litmus-
Bug 451915 - move Firefox/Places bugs to Firefox/Bookmarks and History. Remove all bugspam from this move by filtering for the string "places-to-b-and-h".

In Thunderbird 3.0b, you do that as follows:
Tools | Message Filters
Make sure the correct account is selected. Click "New"
Conditions: Body   contains   places-to-b-and-h
Change the action to "Delete Message".
Select "Manually Run" from the dropdown at the top.
Click OK.

Select the filter in the list, make sure "Inbox" is selected at the bottom, and click "Run Now". This should delete all the bugspam. You can then delete the filter.

Gerv
Component: Places → Bookmarks & History
QA Contact: places → bookmarks
You need to log in before you can comment on or make changes to this bug.