423843 - Subtile passes null to RDFServiceImpl::GetLiteral, triggering ###!!! ASSERTION: null ptr: 'aValue != nsnull'

Status: RESOLVED FIXED

(Firefox :: Extension Compatibility, defect)

Description

[Carsten Book [:Tomcat]]

Attachment: stack

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008031718 Firefox/3.0b5pre ID:2008031718

Steps to reproduce:
-> Install the Subtile Extension https://addons.mozilla.org/en-US/firefox/addon/4906
-> Make this Extension compatible to your Debug Build (its a Beta 3 Extension)
-> Restart Firefox with Subtile Extension enabled
--> Assertion

###!!! ASSERTION: null ptr: 'aValue != nsnull', file /debug/mozilla/rdf/base/src/nsRDFService.cpp, line 1112

Comment 1

[Neil Deakin]

Is this extension using a binary component? If so, it's passing null for a string argument, which would be a bug in the extension.

If it isn't using a binary component, then what is the JS code that is being called when it crashes?

Comment 2

[Jesse Ruderman]

Tomcat, can you get a C++ stack trace for the assertion?

Comment 3

[Jesse Ruderman]

Never mind, timeless says the JS stack (DumpJSStack) is more useful for this bug than the C++ stack.

Comment 4

[timeless]

for reference
components/ilUtilService.js:109
        value=this.RDF.GetLiteral(value);

tomcat provided the correct stack. however it's a bug in the extension, so it should be in some other product.

Comment 5

[Jesse Ruderman]

timeless agrees with the bug 421720 comment 7 doctrine ("abusing a scriptable API should not trigger assertions"), but thinks there's already a bug report about this assertion being bogus, so he decided that this bug report should be about fixing the extension.

Comment 6

[Michel Gutierrez]

All right, i see the problem.

I've made a fix, it is available at http://www.subtile.net/subtile-1.3b1.xpi

If someone can verify the error does not appear anymore, i'll submit version 1.3 of Subtile to addons.mozilla.org.

Comment 7

[Carsten Book [:Tomcat]]

(In reply to comment #6)
> All right, i see the problem.
> 
> I've made a fix, it is available at http://www.subtile.net/subtile-1.3b1.xpi
> 
> If someone can verify the error does not appear anymore, i'll submit version
> 1.3 of Subtile to addons.mozilla.org.
> 

Hi Michel, i don't see this assertion with your 1.3b1 version of subtiles. So verified fixed. Thanks everyone for the great work here.