423966 - Form/input autocomplete not being honored in Fx3

Status: RESOLVED DUPLICATE of bug 362576

(Toolkit :: Password Manager, defect)

Description

[Chris Cooper [:coop] (he/him)]

Attachment: HTML source of form where autocomplete is not being honored.

Showed this to gavin this afternoon.

When I go to the edit users page in Litmus in Fx3, the browser fills in two form fields for me with the login data for my current account. It sticks my email address in the field labeled "authtoken" and my account password in the field labeled "edit_password." I have autocomplete set to off for both fields, and also for the form as a whole. This is not a login form, so I don't really want any data autocompleted anyway, and I certainly don't want the wrong data shoehorned in like this. 

Note: autocomplete doesn't happen on Fx3 if the user *does* already have an authtoken and that field comes back already populated from the database.

Fx2 works as expected. Both fields remain empty.

I've attached the HTML that gets generated for that page. If access to the actual Litmus app would help, I can provide that too.

Fx2 version: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080201 Firefox/2.0.0.12 -> works

Fx3 version: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008031904 Minefield/3.0b5pre -> fails

Comment 1

[:Gavin Sharp [email: [e-mail]]]

Likely a regression from bug 380222. We no longer use the form input names to determine whether to autofill, so in cases like these we'll mistakenly detect the form fields as a login form.

Comment 2

[Justin Dolske [:Dolske]]

Two issues here...

1) autocomplete being ignored. --> bug 362576

2) filling in username in the wrong field...

This is a hard case to get right without breaking other use cases, and is basically wontfix because it's working as expected. :/ Although it would be less of a problem with a solution to 362576.

One workaround would be have the server stick in a hidden autocomplete=off input right before the password fields, with the value preset to the email address (or bogus value to prevent anything from being filled in). Or split out the password fields to a separate form/page.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> 2) filling in username in the wrong field...
> 
> This is a hard case to get right without breaking other use cases, and is
> basically wontfix because it's working as expected. :/

No, it's not working as expected. Fx should remember the name of the fields storing the name and password in the first place, and then only give them back when it sees the *same* field names. I just filed bug 424268 reporting the same problem in Bugzilla. Please reconsider.