Add-ons rating stars now a grid of 11x11 icons

RESOLVED FIXED in Firefox 3 beta5

Status

()

P1
normal
RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: faaborg, Assigned: reed)

Tracking

Trunk
Firefox 3 beta5
Points:
---
Bug Flags:
blocking-firefox3 +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 1 obsolete attachment)

(Reporter)

Description

11 years ago
Created attachment 310595 [details]
Example of the new layout

The addons rating stars are now in a grid of 12x12 icons, instead of the previous (I think) 11x12.  We will need a small css change for the new format.

The reason we are making this change is streamline both the creation and deployment of icons, since 11x12 is one of the only non matching dimensions in the entire product, and any design firm we work with will likely forget to tweak the files before sending.

An example file is attached.
(Reporter)

Comment 1

11 years ago
We need to land this patch with the next drop of icons, requesting blocking.
Flags: blocking-firefox3?
(Assignee)

Updated

11 years ago
Assignee: nobody → reed
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta5
Flags: blocking-firefox3? → blocking-firefox3+
(Assignee)

Comment 2

11 years ago
The example is 55x66... Is that really the size you want?
(In reply to comment #0)
> The addons rating stars are now in a grid of 12x12 icons, instead of the

(In reply to comment #2)
> The example is 55x66... Is that really the size you want?

Simple math implies not, and that we'd be expecting something more along the lines of 60x72.

Alex, did you script clip things, or did you mean that the icons were now 11x11, not 12x12?
Just talked to Alex:
 - the icons are 11x11
 - we will be adding 1px of padding on the right and the bottom
 - the file will be 60x72
 - rows will be 12px high
(Reporter)

Comment 5

11 years ago
Created attachment 310838 [details]
ratings.png
Attachment #310595 - Attachment is obsolete: true
(Reporter)

Comment 6

11 years ago
Created attachment 310839 [details]
ratings-aero.png
(Reporter)

Comment 7

11 years ago
sorry about that, the source material was 11x11 and I didn't realize that, new files attached.
(Assignee)

Updated

11 years ago
Depends on: 424028
(Assignee)

Comment 8

11 years ago
Created attachment 310930 [details] [diff] [review]
patch - v1

I believe this is correct, but I'm not 100% sure.
Attachment #310930 - Flags: review?(rflint)
Attachment #310930 - Flags: review?(rflint) → review+
(Assignee)

Comment 9

11 years ago
<mconnor> a=me
Status: NEW → ASSIGNED
(Assignee)

Updated

11 years ago
Summary: Addons rating stars now a grid of 12x12 icons → Add-ons rating stars now a grid of 11x11 icons
(Assignee)

Comment 10

11 years ago
Checking in toolkit/themes/winstripe/mozapps/extensions/extensions.css;
/cvsroot/mozilla/toolkit/themes/winstripe/mozapps/extensions/extensions.css,v  <--  extensions.css
new revision: 1.52; previous revision: 1.51
done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.