424017 - list of offline apps broken on non-mac platforms

Status: RESOLVED FIXED

(Firefox :: General, defect, P2)

Description

[Dave Camp (:dcamp)]

Attachment: fix

The patch in bug 397417 tried to use utilityOverlay.js to share getOfflineAppUsage() between browser.js and advanced.js, but that doesn't work on non-mac platforms.  Attached patch gives each their own copy of the function (ugh).

Comment 1

[Dave Camp (:dcamp)]

I'd like to get this in to beta5 if possible

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #1)
> I'd like to get this in to beta5 if possible

Right now I'm thinking we can do this after beta; if you think it needs to be in the beta, please retarget and set to P1 and explain why.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Would be nice to get some browser chrome tests in for this stuff.

Comment 4

[Dave Camp (:dcamp)]

Checking in base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.1015; previous revision: 1.1014
done
Checking in base/content/utilityOverlay.js;
/cvsroot/mozilla/browser/base/content/utilityOverlay.js,v  <--  utilityOverlay.js
new revision: 1.64; previous revision: 1.63
done
Checking in components/preferences/advanced.js;
/cvsroot/mozilla/browser/components/preferences/advanced.js,v  <--  advanced.js
new revision: 1.35; previous revision: 1.34
done