424039 - Center favicon in location bar autocomplete

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Ed Lee :Mardak]

Attachment: center -4, center -3, trunk

Right now it's left aligned and has lots of space to the right.

Also, we could shift it down slightly per beltzner.

This screenshot shows the favicon for 3 versions:
centered and downshifted 4 (not 4 pixels)
centered and downshifted 3
trunk: left aligned

Comment 1

[Ed Lee :Mardak]

Attachment: v1

This does middle one in the screenshot.

Comment 2

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310688 [details]
center -4, center -3, trunk

uir+ for center & downshift 4px

Comment 3

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310690 [details] [diff] [review]
v1

whee!

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

(In reply to comment #2)
> (From update of attachment 310688 [details])
> uir+ for center & downshift 4px

Whoops. 3px. Not 4px. _3_.

Comment 5

[Ed Lee :Mardak]

Checking in toolkit/themes/gnomestripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/themes/pinstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/themes/winstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.30; previous revision: 1.29
done

Comment 6

[Stephen Donner [:stephend] Not actively reading bugmail]

in-litmus+:

https://litmus.mozilla.org/show_test.cgi?id=5210

Comment 7

[Stephen Donner [:stephend] Not actively reading bugmail]

Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre