Closed Bug 424039 Opened 13 years ago Closed 13 years ago

Center favicon in location bar autocomplete

Categories

(Firefox :: Theme, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
Firefox 3 beta5

People

(Reporter: Mardak, Assigned: Mardak)

Details

Attachments

(2 files)

Right now it's left aligned and has lots of space to the right.

Also, we could shift it down slightly per beltzner.

This screenshot shows the favicon for 3 versions:
centered and downshifted 4 (not 4 pixels)
centered and downshifted 3
trunk: left aligned
Attachment #310688 - Flags: ui-review?(beltzner)
Attached patch v1Splinter Review
This does middle one in the screenshot.
Assignee: nobody → edilee
Status: NEW → ASSIGNED
Attachment #310690 - Flags: review?(beltzner)
Attachment #310690 - Flags: approval1.9?
Comment on attachment 310688 [details]
center -4, center -3, trunk

uir+ for center & downshift 4px
Attachment #310688 - Flags: ui-review?(beltzner) → ui-review+
Comment on attachment 310690 [details] [diff] [review]
v1

whee!
Attachment #310690 - Flags: review?(beltzner)
Attachment #310690 - Flags: review+
Attachment #310690 - Flags: approval1.9?
Attachment #310690 - Flags: approval1.9+
(In reply to comment #2)
> (From update of attachment 310688 [details])
> uir+ for center & downshift 4px

Whoops. 3px. Not 4px. _3_.
Checking in toolkit/themes/gnomestripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/gnomestripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/themes/pinstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/pinstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.20; previous revision: 1.19
done
Checking in toolkit/themes/winstripe/global/autocomplete.css;
/cvsroot/mozilla/toolkit/themes/winstripe/global/autocomplete.css,v  <--  autocomplete.css
new revision: 1.30; previous revision: 1.29
done
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3 beta5
Verified FIXED using:

Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.4; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre

-and-

Mozilla/5.0 (Windows; U; Windows NT 6.0; en-US; rv:1.9b5pre) Gecko/2008032204 Minefield/3.0b5pre
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.