424056 - Need class=external for most links on the Licensing & Trademarks page

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Stephen Donner [:stephend] Not actively reading bugmail]

Summary: Need class=external for most links on the Licensing & Trademarks page

URL: https://www-firefox3.stage.mozilla.com/en-US/about/licensing.html

Sorry for not pointing this out when I verified bug 420387.

We need |class=external| for all of the following links except for "Mozilla End-User License Agreements" (such as we have on https://www-firefox3.stage.mozilla.com/en-US/about/get-involved.html)

<ul>
<li><a href="http://www.mozilla.org/foundation/trademarks/">Mozilla Trademark and Logo Usage Policies</a></li>
<li><a href="/en-US/legal/eula/">Mozilla End-User License Agreements</a></li>
<li><a href="http://www.mozilla.org/MPL/">Source Code Licensing Terms</a></li>
<li><a href="http://www.mozilla.org/foundation/licensing/website-markup.html">Website Markup Usage Policy</a></li>
</ul>

Comment 1

[Steven Garrity [:sgarrity]]

These external links have been updated in r11464.

This brings up a bit of an issue with the 'external' class. Note the 'Mozilla Public License' link in the first paragraph. We're leaving a bit of an extra space for the arrow on the right of the text. However, when in-line, this extra space looks odd (a bit like a typo).

I'm not sure how to get around this. Not use the 'external' links when inline?

Comment 2

[Steven Garrity [:sgarrity]]

After a chat with John and The Royal Order, we're going to leave off "external" links when they are in-line in a paragraph. Not ideal, but it works.

Updated in r11636.

Comment 3

[Stephen Donner [:stephend] Not actively reading bugmail]

Thanks!  Verified FIXED.