align="start" needs to be added for checkboxes

VERIFIED FIXED in mozilla1.0

Status

SeaMonkey
Preferences
P3
normal
VERIFIED FIXED
18 years ago
14 years ago

People

(Reporter: Henrik Gemal, Assigned: Blake Ross)

Tracking

Trunk
mozilla1.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments)

(Reporter)

Description

18 years ago
To avoid to ugly UI problem of "selecting" text beyond the text the 
autostretch="never" needs to be added.
Will attach screenshot and patch
(Reporter)

Comment 1

18 years ago
Created attachment 10082 [details]
screenshot (before and after autostretch="never")
(Reporter)

Comment 2

18 years ago
Created attachment 10086 [details] [diff] [review]
autostretch="never" added where needed
added patch kw so this can be reviewed/checked in. over to ben who owns the pref
ui.
Assignee: matt → ben
Keywords: patch
(Assignee)

Comment 4

18 years ago
I'll review and check this in tomorrow

(Henrik: thanks for the patch, but unified diffs are preferred and easier to 
read. just specify the -u parameter)
Assignee: ben → BlakeR1234
(Assignee)

Updated

18 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

18 years ago
OS: Windows 98 → All
Hardware: PC → All
(Assignee)

Updated

18 years ago
Keywords: approval, review
(Assignee)

Comment 5

18 years ago
morse, do you approve of the cookie changes here?

Comment 6

18 years ago
I don't disapprove.  However, I'm not sure if I'm the owner here or not.  I'm 
the owner of all cookie and wallet UI but ben is the owner of the pref panels.  
This is that fuzzy area between the two so I guess you could argue that 
either one of us is the owner.  If I'm the owner, I approve.
(Assignee)

Comment 7

18 years ago
Want to do this throughout prefs dialog.
Summary: autostretch="never" needs to be added → autostretch="never" needs to be added for checkboxes in prefs window
Target Milestone: --- → mozilla1.0
(Assignee)

Comment 8

18 years ago
I'll take this back if I get time later.
Assignee: blakeross → matt
Status: ASSIGNED → NEW
nav triage: this is not a beta stopper.
Assignee: matt → blakeross
Keywords: nsbeta1 → nsbeta1-
(Reporter)

Comment 10

18 years ago
basiclly it now seems that only checkboxes are affected. Most others are 
correct. What is the correct way of fixing this one?
Byt adding autostretch="never" to the checkbox itself???
Keywords: approval, patch, review
(Reporter)

Comment 12

18 years ago
what does "a=ben@netscape.com". You are gonna do it?

Comment 13

18 years ago
This was checked in today thus marking fixed. Btw, where's the r=?
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED
(Assignee)

Comment 14

18 years ago
Thanks, but I'm well aware of what I checked in, and I left this open for a 
reason -- to fix remaining cases.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Summary: autostretch="never" needs to be added for checkboxes in prefs window → autostretch="never" needs to be added for checkboxes

Comment 15

18 years ago
Created attachment 26732 [details] [diff] [review]
patch for bookmarks, forms, passwords, images & cookies pref panels

Comment 16

18 years ago
Adding patch & review keywords
Keywords: patch, review

Updated

18 years ago
Assignee: blakeross → walk84
Status: REOPENED → NEW

Comment 17

18 years ago
r=timeless. does a=ben still apply?
yes. a=ben for the most recent patch
(Assignee)

Comment 19

18 years ago
Stephen: thanks for the patch.

Since when are bugs on which the owner has worked reassigned without the owner's 
permission?  Back to me; there's still work to be done here.
Assignee: walk84 → blakeross

Comment 20

17 years ago
Created attachment 33140 [details] [diff] [review]
patch pref-winhooks.xul

Comment 21

17 years ago
r=timeless
sr=ben. Hm. I didn't place the autostretch box around this because this type of
thing causes problems when the window is made smaller or the text grows in
length. However this is a bug in the widget that should be separately addressed.

We'd really like to not have to put autostretch boxes around all these things. 
(Reporter)

Comment 23

17 years ago
"However this is a bug in the widget that should be separately addressed."
has this been reported?
Fix is in.
Status: NEW → RESOLVED
Last Resolved: 18 years ago17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 25

17 years ago
missing checkboxes:
- Advanced -> "Enable JavaScript for Mail and News"
- Advanced -> System -> "Alert me if other applications...."
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Reporter)

Comment 26

17 years ago
If I have other places where this is missing (but not in prefs) should I just 
file new bugs?
Keywords: nsbeta1-, patch, review
(Assignee)

Comment 27

17 years ago
usability/polish 0.9.4.
Target Milestone: mozilla1.0 → mozilla0.9.4

Comment 28

17 years ago
Changing summary to reflect new XUL 1.0 layout changes.
Summary: autostretch="never" needs to be added for checkboxes → align="start" needs to be added for checkboxes
(Assignee)

Updated

17 years ago
Target Milestone: mozilla0.9.4 → mozilla0.9.5

Comment 29

17 years ago
Mass moving lower-priority bugs to 0.9.6 (with Blake's pre-consent) to make room
for remaining 0.9.4/eMojo bugs and MachV planning, performance and feature work.
 If anyone disagrees with the new target, please let me know.
Target Milestone: mozilla0.9.5 → mozilla0.9.6
(Assignee)

Updated

17 years ago
Status: REOPENED → ASSIGNED
Target Milestone: mozilla0.9.6 → mozilla1.0
(Assignee)

Comment 30

17 years ago
Marking fixed, will handle other cases as they crop up.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
much nicer. vrfy fixed:

linux - 2001.11.01.12
winNT - 2001.10.31.03
mac 10.1 - 2001.10.31.13
Status: RESOLVED → VERIFIED
Product: Browser → Seamonkey
You need to log in before you can comment on or make changes to this bug.