424066 - CheckSameOriginURI reports spurious error during routine internal comparison

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Mike Shaver (:shaver emeritus)]

Another in the tradition of bug 246699: even with that patch, you can get errors that don't have context information, though it looks like the GetPropertyDenied code should be going through the SetPendingException code.  Could be the "%hs" in the specifier?

Comment 1

[Mike Shaver (:shaver emeritus)]

I have no idea what I was thinking when I summarized this bug.

The problem is that nsScriptSecurityManager::CheckSameOriginURI always calls ReportError with a null cx, which means no informative exception, just an error console spew.  Could maybe get away with using the context thread stack, but I wonder if our error messages would actually be useful there.

Comment 2

[Boris Zbarsky [:bzbarsky]]

Mike, the right solution here is to have the caller (the DOM error reporter function) pass PR_FALSE for the last argument and report the correct error itself.  That correct error being that we're leaving information off the onerror event becase it's firing cross-origin.

That's assuming we want to report this at all.

In fact, I'd say we want to move toward having CheckSameOriginURI never report anything.

Comment 3

[Mike Shaver (:shaver emeritus)]

Yeah, that's the patch that mrbkap suggested, and that I'm trying to figure out how to mochitest now.

Comment 4

[Mike Shaver (:shaver emeritus)]

Fixing summary.

Comment 5

[Mike Shaver (:shaver emeritus)]

Attachment: make NS_ScriptErrorReporter not whine about inequal origin URLs when constructing exceptions

bz and mrbkap both suggested this patch, so asking either of them for review.

https://bugzilla.mozilla.org/show_bug.cgi?id=424974 tracks the test infrastructure for making sure we don't regress.

I'd love to get this simple fix into b5, to eliminate one  way our error reporting can send extension authors off into the weeds while they're updating their extension for FF3.  It's already wasted too much of John Barton's scarce time as it is!

(Sadly, other such cases remain, but I'm not done yet with FF3.)

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311574 [details] [diff] [review]
make NS_ScriptErrorReporter not whine about inequal origin URLs when constructing exceptions

a1.9b5=beltzner

Comment 7

[Reed Loden [:reed]]

Landed for b5 with beltzner's blessing.

Checking in dom/src/base/nsJSEnvironment.cpp;
/cvsroot/mozilla/dom/src/base/nsJSEnvironment.cpp,v  <--  nsJSEnvironment.cpp
new revision: 1.397; previous revision: 1.396
done