424159 - win32 unit test machines need new SDK

Status: RESOLVED FIXED

(Release Engineering :: General, defect, P2)

Description

[[e-mail] (:bhearsum)]

I was told there was a patch landed last night that worked fine on the try server and blew up on the unit test machines because they don't have the new SDK on them. We upgraded the Build machines a couple months ago but I guess these were missed because they weren't on our radar :(.

Here's the instructions we followed when upgrading the build machines:
http://wiki.mozilla.org/ReferencePlatforms/Win32#Install_Microsoft.C2.AE_Windows.C2.AE_Software_Development_Kit_Update_for_Windows_Vista

INCLUDE and LIB will need to be adjusted to have the new SDK first. You should also set SDKDIR should also be set. Here's what the try server uses, for what it's worth: http://mxr.mozilla.org/mozilla/source/tools/buildbotcustom/env.py

Comment 1

[Jim Mathies [:jimm]]

here's the breakage from last night - 
http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1205993191.1205993643.10935.gz

Comment 2

[Reed Loden [:reed]]

wasn't only the Firefox win32 unit test machines... other machines busted by this patch:
fxdbug-win32-tb -- http://tinderbox.mozilla.org/showlog.cgi?log=Firefox/1205993760.1205995347.14436.gz
sea-win32-tbox -- http://tinderbox.mozilla.org/showlog.cgi?log=SeaMonkey/1205994660.1205997272.18666.gz

These both went green after the patch was backed out.

Comment 3

[Jim Mathies [:jimm]]

Two problems now actually, those are different. I'm going to have to modify the patch to use getprocaddress on the event calls I'm using. The build problem though is still present because we'll need the headers. (I could define this stuff manually in the code, but we shouldn't have too if the sdk is to date.)

Comment 4

[Rob Campbell [:rc] (:robcee)]

I'm going to schedule some down-time to get this installed on qm-win2k3-01 early Monday morning.

Comment 5

[Damon Sicore (:damons)]

Should this really block the beta?  It's marked as a P1.  Getting this monday is sorta late, right?

Comment 6

[Mike Beltzner [:beltzner, not reading bugmail]]

Doesn't block beta, no, as the bug which requires this doesn't block beta. If this turns out to also block bug 416683, though, it will block beta.

Jim: does bug 4166183 depend on this?

Comment 7

[Jim Mathies [:jimm]]

Nope, unrelated. This is tied to new apis for parental controls related stuff in vista, bug 416683 is tied to the virus scanning we added a little while back. 

Comment 8

[Rob Campbell [:rc] (:robcee)]

These are installed but not currently referenced in the buildbot configs. Not sure we need to add the include, libs and sdk directories to the path or not.

Comment 9

[Rob Campbell [:rc] (:robcee)]

Attachment: SDK 6.0 vars.patch

path additions for mozbuild unittest box

Comment 10

[Rob Campbell [:rc] (:robcee)]

Checking in mozbuild.py;
/cvsroot/mozilla/tools/buildbot-configs/testing/unittest/mozbuild.py,v  <--  mozbuild.py
new revision: 1.16; previous revision: 1.15
done

Comment 11

[Rob Campbell [:rc] (:robcee)]

applied to master