Closed Bug 424253 Opened 14 years ago Closed 14 years ago

Update Minotaur Expect Script, home directory access scripts

Categories

(Testing Graveyard :: Minotaur, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: cmtalbert, Unassigned)

Details

Attachments

(1 file)

Something changed either in Leopard or in the way that we package our dmg's, and the installer for Mac broke on Leopard. I have fixed the issue, and a patch is attached.  Along the way, I noticed some python oddness in the way the code handled the HOME directory on linux and mac systems, no doubt owing to my lack of understanding of python when I wrote that code.  So, I fixed those as well.

Also discovered that the run-minotaur.py change to allow that code to print out a help message without specifying the -h option somehow never got checked in.  That was part of an earlier bug, and was reviewed, but got overlooked on checkin. That is also in this patch.

Note that these changes are NOT in the core are of Minotaur (the part that creates and analyzes diffs) and as such they are pretty safe changes.  They will have no effect on generated files.
Attachment #310876 - Flags: review?(rcampbell)
Comment on attachment 310876 [details] [diff] [review]
Update Minotaur Run and Install Files

I think this looks good, but I haven't tried it. Nothing jumps out at me, anyway.
Attachment #310876 - Flags: review?(rcampbell) → review+
I tested it before submitting patch.  Used this code to generate the mac 3b3->3b4 diffs (only platform specific change on this was for mac to install on leopard), and the $HOME stuff only affected *nix based OS's.

Checked in on trunk.
Checking in testing/release/minotaur/installdmg-expect.ex;
/cvsroot/mozilla/testing/release/minotaur/installdmg-expect.ex,v  <--  installdmg-expect.ex
new revision: 1.2; previous revision: 1.1
done
Checking in testing/release/minotaur/installdmg.sh;
/cvsroot/mozilla/testing/release/minotaur/installdmg.sh,v  <--  installdmg.sh
new revision: 1.2; previous revision: 1.1
done
Checking in testing/release/minotaur/mozDownload.py;
/cvsroot/mozilla/testing/release/minotaur/mozDownload.py,v  <--  mozDownload.py
new revision: 1.4; previous revision: 1.3
done
Checking in testing/release/minotaur/mozInstall.py;
/cvsroot/mozilla/testing/release/minotaur/mozInstall.py,v  <--  mozInstall.py
new revision: 1.3; previous revision: 1.2
done
Checking in testing/release/minotaur/run-minotaur.py;
/cvsroot/mozilla/testing/release/minotaur/run-minotaur.py,v  <--  run-minotaur.py
new revision: 1.3; previous revision: 1.2
done

--> FIXED, thanks for the review Robcee!
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → FIXED
Mass moving Minotaur bugs to Testing : Minotaur. Filter on MinotaurMassMove to ignore.
Component: Testing → Minotaur
Product: Core → Testing
QA Contact: testing → minotaur
Version: Trunk → unspecified
Product: Testing → Testing Graveyard
You need to log in before you can comment on or make changes to this bug.