424262 - Ratings stars show a compressed composite of entire image block

Status: VERIFIED FIXED

(Toolkit :: Add-ons Manager, defect, P1)

Description

[Ed Hume]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005 Minefield/3.0b5pre

The ratings icon shows the appropriate stars on the top recommended add-on, but shows a vertically-compressed composite of the entire image block in subsequent recommended add-ons.

Reproducible: Always

Steps to Reproduce:
1. Open Add-ons window
2. Select Get Add-ons tab
3. Wait for recommended add-ons to appear
Actual Results:  
The ratings icon shows the appropriate stars on the top recommended add-on, but shows a vertically-compressed composite of the entire image block in subsequent recommended add-ons.

Expected Results:  
Each recommended add-on should show a single line of stars.

This shows up both in the default theme and in my theme, which uses the older orange stars.

This appears to be a regression.

Comment 1

[Ed Hume]

Attachment: Screenshot showing bug

Comment 2

[Ed Hume]

Attachment: This screenshot shows the vertical compression more clearly

Comment 3

[Ed Hume]

Attachment: All recommended add-ons show compression bug.

Comment 4

[Ed Hume]

The regression occurred between the 2008-03-18 and 2008-03-19 nightlies.

Comment 5

[Dave Townsend [:mossop]]

This is an expected regression from bug 423137. It will be resolved when AMO updates.

Comment 6

[Dave Townsend [:mossop]]

AMO has pushed their schedule back too far so we'll take a fix for this for b5.

Comment 7

[Dave Townsend [:mossop]]

Attachment: Restrict invalid ratings

This ignores ratings < 0 and anything > 5 is constrained to be 5.

Comment 8

[Dave Townsend [:mossop]]

Attachment: with unit tests

Comment 9

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 310970 [details] [diff] [review]
with unit tests

<@gavin> r=me
a=beltzner

Comment 10

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 310970 [details] [diff] [review]
with unit tests

Math.min(5, rating); would be clearer, I think.

Comment 11

[Dave Townsend [:mossop]]

Attachment: as checked in

Checking in toolkit/mozapps/extensions/src/nsAddonRepository.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsAddonRepository.js,v  <--  nsAddonRepository.js
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug424262.js,v
done
Checking in toolkit/mozapps/extensions/test/unit/test_bug424262.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug424262.js,v  <--  test_bug424262.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v  <--  test_bug424262.xml
initial revision: 1.1
done

Comment 12

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre.   Star icons are back.