39.33 KB, image/png
35.69 KB, image/png
23.28 KB, image/png
10.53 KB, patch
|Details | Diff | Splinter Review|
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005 Minefield/3.0b5pre Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005 Minefield/3.0b5pre The ratings icon shows the appropriate stars on the top recommended add-on, but shows a vertically-compressed composite of the entire image block in subsequent recommended add-ons. Reproducible: Always Steps to Reproduce: 1. Open Add-ons window 2. Select Get Add-ons tab 3. Wait for recommended add-ons to appear Actual Results: The ratings icon shows the appropriate stars on the top recommended add-on, but shows a vertically-compressed composite of the entire image block in subsequent recommended add-ons. Expected Results: Each recommended add-on should show a single line of stars. This shows up both in the default theme and in my theme, which uses the older orange stars. This appears to be a regression.
The regression occurred between the 2008-03-18 and 2008-03-19 nightlies.
This is an expected regression from bug 423137. It will be resolved when AMO updates.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
AMO has pushed their schedule back too far so we'll take a fix for this for b5.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
Created attachment 310965 [details] [diff] [review] Restrict invalid ratings This ignores ratings < 0 and anything > 5 is constrained to be 5.
Assignee: nobody → dtownsend
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Created attachment 310970 [details] [diff] [review] with unit tests
Attachment #310965 - Attachment is obsolete: true
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta5
Attachment #310970 - Flags: review?(rstrong)
Attachment #310970 - Flags: review?(rstrong) → review?(gavin.sharp)
Comment on attachment 310970 [details] [diff] [review] with unit tests <@gavin> r=me a=beltzner
Comment on attachment 310970 [details] [diff] [review] with unit tests Math.min(5, rating); would be clearer, I think.
Created attachment 310991 [details] [diff] [review] as checked in Checking in toolkit/mozapps/extensions/src/nsAddonRepository.js; /cvsroot/mozilla/toolkit/mozapps/extensions/src/nsAddonRepository.js,v <-- nsAddonRepository.js new revision: 1.4; previous revision: 1.3 done RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug424262.js,v done Checking in toolkit/mozapps/extensions/test/unit/test_bug424262.js; /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug424262.js,v <-- test_bug424262.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v done Checking in toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml; /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v <-- test_bug424262.xml initial revision: 1.1 done
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago → 11 years ago
Resolution: --- → FIXED
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre. Star icons are back.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.