Ratings stars show a compressed composite of entire image block

VERIFIED FIXED in mozilla1.9beta5

Status

()

P1
normal
VERIFIED FIXED
11 years ago
11 years ago

People

(Reporter: ehume, Assigned: mossop)

Tracking

unspecified
mozilla1.9beta5
x86
Windows XP
Points:
---
Bug Flags:
blocking1.9 +
in-testsuite +

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(4 attachments, 2 obsolete attachments)

(Reporter)

Description

11 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9b5pre) Gecko/2008032005 Minefield/3.0b5pre

The ratings icon shows the appropriate stars on the top recommended add-on, but shows a vertically-compressed composite of the entire image block in subsequent recommended add-ons.

Reproducible: Always

Steps to Reproduce:
1. Open Add-ons window
2. Select Get Add-ons tab
3. Wait for recommended add-ons to appear
Actual Results:  
The ratings icon shows the appropriate stars on the top recommended add-on, but shows a vertically-compressed composite of the entire image block in subsequent recommended add-ons.

Expected Results:  
Each recommended add-on should show a single line of stars.

This shows up both in the default theme and in my theme, which uses the older orange stars.

This appears to be a regression.
(Reporter)

Comment 1

11 years ago
Created attachment 310896 [details]
Screenshot showing bug
(Reporter)

Comment 2

11 years ago
Created attachment 310898 [details]
This screenshot shows the vertical compression more clearly
(Reporter)

Comment 3

11 years ago
Created attachment 310905 [details]
All recommended add-ons show compression bug.
(Reporter)

Comment 4

11 years ago
The regression occurred between the 2008-03-18 and 2008-03-19 nightlies.
(Assignee)

Comment 5

11 years ago
This is an expected regression from bug 423137. It will be resolved when AMO updates.
Status: UNCONFIRMED → RESOLVED
Last Resolved: 11 years ago
Resolution: --- → INVALID
(Assignee)

Comment 6

11 years ago
AMO has pushed their schedule back too far so we'll take a fix for this for b5.
Status: RESOLVED → UNCONFIRMED
Resolution: INVALID → ---
(Assignee)

Comment 7

11 years ago
Created attachment 310965 [details] [diff] [review]
Restrict invalid ratings

This ignores ratings < 0 and anything > 5 is constrained to be 5.
Assignee: nobody → dtownsend
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
(Assignee)

Comment 8

11 years ago
Created attachment 310970 [details] [diff] [review]
with unit tests
Attachment #310965 - Attachment is obsolete: true
Flags: blocking-firefox3+
Priority: -- → P1
Target Milestone: --- → Firefox 3 beta5
Attachment #310970 - Flags: review?(rstrong) → review?(gavin.sharp)
Comment on attachment 310970 [details] [diff] [review]
with unit tests

<@gavin> r=me
a=beltzner
Attachment #310970 - Flags: review?(gavin.sharp)
Attachment #310970 - Flags: review+
Attachment #310970 - Flags: approval1.9b5+
Comment on attachment 310970 [details] [diff] [review]
with unit tests

Math.min(5, rating); would be clearer, I think.
(Assignee)

Comment 11

11 years ago
Created attachment 310991 [details] [diff] [review]
as checked in

Checking in toolkit/mozapps/extensions/src/nsAddonRepository.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsAddonRepository.js,v  <--  nsAddonRepository.js
new revision: 1.4; previous revision: 1.3
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug424262.js,v
done
Checking in toolkit/mozapps/extensions/test/unit/test_bug424262.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/test_bug424262.js,v  <--  test_bug424262.js
initial revision: 1.1
done
RCS file: /cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v
done
Checking in toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml;
/cvsroot/mozilla/toolkit/mozapps/extensions/test/unit/data/test_bug424262.xml,v  <--  test_bug424262.xml
initial revision: 1.1
done
Attachment #310970 - Attachment is obsolete: true
Attachment #310991 - Flags: review+
(Assignee)

Updated

11 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 11 years ago11 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Verified fix on Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.5; en-US; rv:1.9b5pre) Gecko/2008032304 Minefield/3.0b5pre.   Star icons are back.
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.