424363 - Customize Toolbar ▸ Restore Default Set uses gtk-refresh instead of gtk-revert-to-saved

Status: VERIFIED FIXED

(Firefox :: Theme, defect)

Description

[Andrés Delfino]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032107 Minefield/3.0b5pre
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032107 Minefield/3.0b5pre

Since we are not refreshing anything, but reverting changes gtk-undo should be used.

Reproducible: Always

Comment 1

[Andrés Delfino]

Attachment: Screenshot.

Comment 2

[Michael Monreal [:micmon]]

If anything, use gtk-revert-to-saved. The icon gtk-undo is for undoing one step, which is not the case here. So, gtk-revert-to-saved or no icon.

Comment 3

[Andrés Delfino]

(In reply to comment #2)
> If anything, use gtk-revert-to-saved. The icon gtk-undo is for undoing one
> step, which is not the case here. So, gtk-revert-to-saved or no icon.
> 

You're absolutely right; actually, I was going to morph this bug.

I think the gtk-revert-to-saved works fine here.

Comment 4

[Justin Dolske [:Dolske]]

Attachment: Patch v.1

Comment 5

[Justin Dolske [:Dolske]]

Attachment: Screenshot (patch v.1)

Comment 6

[Justin Dolske [:Dolske]]

(New icon is the top in the screenshot, old icon is the bottom).

The change to customizeToolbarSheet.xul probably isn't needed (seems to be mac only), but I figured I'd just keep them more or less in sync.

Comment 7

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 350557 [details] [diff] [review]
Patch v.1

>diff --git a/toolkit/content/customizeToolbar.xul b/toolkit/content/customizeToolbar.xul

>+    <button label="&restoreDefaultSet.label;" oncommand="restoreDefaultSet();"
>+icon="revert"/>

What's with the odd indent?

Comment 8

[Alex Faaborg [:faaborg] (Firefox UX)]

Comment on attachment 350558 [details]
Screenshot (patch v.1)

I'm assuming these are the correct icons. I actually don't know what gtk-revert-to-saved looks like.

Comment 9

[Justin Dolske [:Dolske]]

Pushed http://hg.mozilla.org/mozilla-central/rev/f03bb4a3ce53

Comment 10

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 350557 [details] [diff] [review]
Patch v.1

a191=beltzner

Comment 11

[Justin Dolske [:Dolske]]

Pushed to 1.9.1: http://hg.mozilla.org/releases/mozilla-1.9.1/rev/a511a6815305

Comment 12

[Tony Chung [:tchung]]

Verified fix on Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.1b3pre) Gecko/20090122 Shiretoko/3.1b3pre
and Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9.2a1pre) Gecko/20090122 Minefield/3.2a1pre

Comment 13

[Alex Faaborg [:faaborg] (Firefox UX)]

This bug's priority relative to the set of other polish bugs is:
P2 - Polish issue that is in a secondary interface, occasionally encountered, and is easily identifiable.

customize toolbar interface is a secondary UI, assuming the icon difference was obvious.