424387 - getBoundingClientRect / getClientRects don't return integers

Status: RESOLVED INVALID

(Core :: DOM: CSS Object Model, defect)

Description

[John Resig]

According to PPK, in Gecko 1.9, the getBoundingClientRect and getClientRects methods no longer return a correct value:
http://www.quirksmode.org/dom/w3c_cssom.html#elementviewm

A simple test case is provided here (click 'Show bounding rectangle'):
http://www.quirksmode.org/dom/tests/rectangles.html

Comment 1

[John Resig]

I forgot to mention but this is also part of the W3C CSSOM working draft:
http://www.w3.org/TR/cssom-view/

Comment 2

[Martijn Wargers (dead)]

See bug 174397, comment 57. It was decided there that float were allowed.
I think there was also a draft spec, but I can't find one, anymore.

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

John just linked to it, and it says getBoundingClientRect/getClientRects can return floats.

John, why do you think this is a bug?

Comment 4

[John Resig]

Ok, I didn't realize that floats were permitted. Based upon the work that PPK did it sounded like this was a problem, I'll contact him, instead. Thanks.

Comment 5

[Martijn Wargers (dead)]

Fwiw, I think I would prefer rounding these numbers too.

Comment 6

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Rounding loses information. If we made these APIs round, then sooner or later we'd want to provide unrounded versions as well. So far I haven't heard of any real problems created by these APIs not rounding. Of course it's easy for toolkits to do the rounding themselves (whereas if we rounded, it would be basically impossible for toolkits to provide unrounded versions).