Closed Bug 424465 Opened 12 years ago Closed 12 years ago
[FIX]CSS border interruption when setting inner
HTML of children of form that has margin-bottom set and no horizontal resize needed .
6.29 KB, image/png
16.64 KB, text/html
1.64 KB, text/html
19.27 KB, image/png
10.70 KB, patch
|Details | Diff | Splinter Review|
4.32 KB, patch
|Details | Diff | Splinter Review|
Can't connect to the site.
I moved the testcase to another location, please see...
I've been minimizing and playing with this a lot and discovered that it only happens if margin-bottom is set on the form enclosing it. I changed from php headers to meta tags and attached here for easy viewing.
Summary: CSS border redraw issue when showing enclosed elements that had display:none → CSS border interruption when showing hidden children of form that has margin-bottom set
Summary: CSS border interruption when showing hidden children of form that has margin-bottom set → CSS border interruption when setting innerHTML of form children that has margin-bottom set and no horizontal resize needed.
Summary: CSS border interruption when setting innerHTML of form children that has margin-bottom set and no horizontal resize needed. → CSS border interruption when setting innerHTML of children of form that has margin-bottom set and no horizontal resize needed.
Component: General → GFX
Product: Firefox → Core
QA Contact: general → general
Rounding bug in the invalidation code?
Unfortunately I can't say, because I am still a C/C++ newbie and I'm not familiar with Mozilla XUL or source code.
I split the 2nd problem into a separate bug: https://bugzilla.mozilla.org/show_bug.cgi?id=425083 Sorry for all the bug spam, I am new to bugzilla (and bug reporting in general).
needs a regression range
Works: 20080206_1337_firefox-3.0b4pre.en-US.win32 Broken: 20080206_1337_firefox-3.0b4pre.en-US.win32 Checkins to module PhoenixTinderbox between 2008-02-06 13:37 and 2008-02-06 14:32 : http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=PhoenixTinderbox&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2008-02-06+13%3A37&maxdate=2008-02-06+14%3A32&cvsroot=%2Fcvsroot Due to bug 414298 I'd say. CC'ng bz and requesting blocking.
of course, should be Broken: 20080206_1432_firefox-3.0b4pre.en-US.win32
Fun times. When reflow branch landed, it removed all the InvalidateDamage() callers. So after that, if a caption or the inner table got resized and the resize area included stuff that's not covered by any kids (the cellspacing in this case), we wouldn't repaint correctly. Bernd, can you check to make sure it's OK to not actually use InvalidateDamage() here? I think it should be fine, but...
Summary: CSS border interruption when setting innerHTML of children of form that has margin-bottom set and no horizontal resize needed. → [FIX]CSS border interruption when setting innerHTML of children of form that has margin-bottom set and no horizontal resize needed.
Comment on attachment 311721 [details] [diff] [review] Proposed fix Looks like my handling of bug 219141 was not correct. Given the history of bug 414298 I would say its time to put some reftests into the tree. At least for this bug the r+ requires reftests to be checked in with the patch.
Attachment #311721 - Flags: review?(bernd_mozilla) → review+
I would love to do that, but reftests can't catch invalidation bugs, since they do a fresh toplevel paint. We need an entirely new test infrastructure, with backend support, to test this sort of thing. :( roc is planning to make Compositor support it, but that's not going to help me write tests for this patch...
I just got very nervous when I looked at the regression chain. So no reftest for now. Indeed hovering with a window makes a new paint and then everything is OK.
Yeah, nervous is right. :(
Attachment #311721 - Flags: superreview?(roc) → superreview+
Comment on attachment 311721 [details] [diff] [review] Proposed fix Requesting approval. This makes sure to invalidate correctly when the inner table or caption size changes.
Flags: blocking1.9? → blocking1.9+
Priority: -- → P2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
verified fixed using the testcases and Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9pre) Gecko/2008041217 Minefield/3.0pre ID:2008041217 --> Verified fixed
Status: RESOLVED → VERIFIED
Attachment #384659 - Flags: review?(bzbarsky) → review+
Pushed test as http://hg.mozilla.org/mozilla-central/rev/4cbb996fbb60
Flags: in-testsuite? → in-testsuite+
You need to log in before you can comment on or make changes to this bug.