Closed
Bug 424613
Opened 16 years ago
Closed 16 years ago
Remove browser/themes/*stripe/browser/bookmarks
Categories
(Firefox :: Theme, defect)
Firefox
Theme
Tracking
()
RESOLVED
FIXED
Firefox 3
People
(Reporter: reed, Assigned: philor)
References
Details
Attachments
(1 file)
31.00 KB,
patch
|
Gavin
:
review+
beltzner
:
approval1.9+
|
Details | Diff | Splinter Review |
browser/themes/winstripe/browser/bookmarks and browser/themes/pinstripe/browser/bookmarks aren't needed anymore. They haven't been used since we swapped to places. gnomestripe doesn't even have a bookmarks folder.
Reporter | ||
Comment 1•16 years ago
|
||
Really don't have time to look into this... can somebody take this?
Assignee: reed → nobody
Status: ASSIGNED → NEW
Assignee | ||
Comment 2•16 years ago
|
||
How on earth could we want to get rid of fun things like "Bookmarks-toolbar.png is only referenced in bookmarksManager.css, and bookmarksManager.css isn't applied to anything, or even jarred up, but wait, Bookmarks-toolbar.png isn't jarred with that name, it's jarred as organizer-toolbar.png, which isn't used anywhere"?
Assignee | ||
Comment 3•16 years ago
|
||
Surprisingly unexciting, for all that: the stuff that wasn't being jarred is just chaff, organizer-toolbar.png isn't used, and the four pinstripe expander images don't have interesting enough history to be worth CVS moves, so I just copied them over to ../places/.
Assignee: nobody → philringnalda
Status: NEW → ASSIGNED
Attachment #316167 -
Flags: review?(gavin.sharp)
Updated•16 years ago
|
Attachment #316167 -
Flags: review?(gavin.sharp) → review+
Assignee | ||
Updated•16 years ago
|
Attachment #316167 -
Flags: approval1.9?
Comment 4•16 years ago
|
||
Comment on attachment 316167 [details] [diff] [review] Fix v.1 a1.9=beltzner
Attachment #316167 -
Flags: approval1.9? → approval1.9+
Assignee | ||
Comment 5•16 years ago
|
||
browser/themes/pinstripe/browser/jar.mn 1.82 browser/themes/pinstripe/browser/bookmarks/Bookmarks-toolbar.png delete browser/themes/pinstripe/browser/bookmarks/addBookmark.css delete browser/themes/pinstripe/browser/bookmarks/bookmark-folder.png delete browser/themes/pinstripe/browser/bookmarks/bookmark-item.png delete browser/themes/pinstripe/browser/bookmarks/bookmarksManager.css delete browser/themes/pinstripe/browser/bookmarks/bookmarksProperties.css delete browser/themes/pinstripe/browser/bookmarks/expander-closed-active.png delete browser/themes/pinstripe/browser/bookmarks/expander-closed.png delete browser/themes/pinstripe/browser/bookmarks/expander-open-active.png delete browser/themes/pinstripe/browser/bookmarks/expander-open.png delete browser/themes/pinstripe/browser/bookmarks/folderarrow-hover.png delete browser/themes/pinstripe/browser/bookmarks/folderarrow.png delete browser/themes/pinstripe/browser/bookmarks/livemark-folder-hover.png delete browser/themes/pinstripe/browser/bookmarks/livemark-folder.png delete browser/themes/pinstripe/browser/bookmarks/livemark-item.png delete browser/themes/pinstripe/browser/places/expander-closed-active.png 1.1 browser/themes/pinstripe/browser/places/expander-closed.png 1.1 browser/themes/pinstripe/browser/places/expander-open-active.png 1.1 browser/themes/pinstripe/browser/places/expander-open.png 1.1 browser/themes/winstripe/browser/jar.mn 1.89 browser/themes/winstripe/browser/bookmarks/Bookmarks-toolbar.png delete browser/themes/winstripe/browser/bookmarks/addBookmark.css delete browser/themes/winstripe/browser/bookmarks/bookmarksManager.css delete browser/themes/winstripe/browser/bookmarks/bookmarksProperties.css delete
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•