424617 - List of threads I've posted in

Status: VERIFIED FIXED

(support.mozilla.org :: Forum, task)

Description

[Jason Barnabe (np)]

Having a list of threads a user has posted in would make it easier to follow up on suggestions. http://support.mozilla.com/tiki-my_tiki.php?locale=en-US provides this, but it has problems.

-You don't get the info you would in a regular thread listing, like who posted last and when
-It's not paginated. Some people have thousands of posts already.

Comment 1

[Jason Barnabe (np)]

Attachment: patch

This introduces the concept of "filters". The filter controls appear at the bottom of thread listings. Users can choose "All posts" or "Containing posts by me". They can also choose the date options (Last 24 hours, etc.) that are currently in production.

There's a special user value "_me" that shows the current user's posts. You can also put a user's name in, but there's no UI to do that.

Comment 2

[Jason Barnabe (np)]

I'd be interested to see how this performs on users with 1000s of posts before it goes live...

Comment 3

[Jason Barnabe (np)]

Attachment: patch 2

Unbitrotted the last patch. Also fixed a bug where the filter would stick when you went to the next page.

There's still a bug where the number of pages in the pagination is wrong. This bug exists today for the date filter, so I'm fine putting this in without fixing it.

Comment 4

[Nelson Ko [:nkoth]]

When I tried attachment 314236 [details] [diff] [review], it seems to take forever... and never ends. I think the IN subquery is not scalable.

Comment 5

[Jason Barnabe (np)]

Attachment: patch v3

You're right, I didn't notice because before I had a small dataset. It was running that subquery once for every row in the database! I thought SQL was smarter than that :)

This new patch runs it once and generates a list of IDs, then uses that. I ran this against Bo in my test DB, who has 1700 posts and it came back quickly. Just to be safe, I limited the number of results returned to 1000.

Comment 6

[Nelson Ko [:nkoth]]

in r13339

Comment 7

[Jason Barnabe (np)]

Now on prod.