button for default action ("Restart Firefox") should be on the left

VERIFIED FIXED in mozilla1.9.1b1

Status

()

VERIFIED FIXED
11 years ago
10 years ago

People

(Reporter: zeniko, Assigned: zeniko)

Tracking

({polish})

Trunk
mozilla1.9.1b1
x86
Windows XP
polish
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

11 years ago
The current button order is appropriate for OS X and GNOME but not for Windows where the default action (usually OK) is listed before the secondary one (usually Cancel).
(Assignee)

Comment 1

10 years ago
Created attachment 335765 [details] [diff] [review]
swap restart and quit button

Ted: Would this patch have to go upstream or is the crash reporter client actually our own?
Attachment #335765 - Flags: review?(ted.mielczarek)
The crash reporter client is ours.
Attachment #335765 - Flags: review?(ted.mielczarek) → review+
Comment on attachment 335765 [details] [diff] [review]
swap restart and quit button

r=me, but could you not swap lines of code around where it's not really necessary? I don't think the code needs to be in the exact order of the buttons with these two buttons.
(Assignee)

Comment 4

10 years ago
Created attachment 336910 [details] [diff] [review]
same patch with no unneeded reordering
Assignee: nobody → zeniko
Attachment #335765 - Attachment is obsolete: true
Status: NEW → ASSIGNED
(Assignee)

Updated

10 years ago
Keywords: checkin-needed

Comment 5

10 years ago
http://hg.mozilla.org/mozilla-central/rev/3f60106dd21a
Status: ASSIGNED → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → mozilla1.9.1b1
verified fixed using : Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9.1b2pre) Gecko/20081014 Minefield/3.1b2pre.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.