424690 - search-go-button don't ignore right click

Status: RESOLVED FIXED

(Firefox :: Search, defect)

Description

[sevenfurnace]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080207 Ubuntu/7.10 (gutsy) Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032405 Minefield/3.0b5pre

when right-clicking on the search button of searchbar, search results should not be loaded in the content area.

Reproducible: Always

Steps to Reproduce:
1. Right click the magnifier button on the searchbar.

Actual Results:  
Toolbar-customization popup is opened, and at the same time search results is loaded in the current tab.

Expected Results:  
Toolbar-customization popup is opened.

Comment 1

[sevenfurnace]

Attachment: patch

checks aEvent.button

Comment 2

[Sylvain Pasche]

That's a regression, it did not happen on Firefox 2 or previous nightlies.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 311285 [details] [diff] [review]
patch

Thanks for the patch!

Comment 4

[Mike Beltzner [:beltzner, not reading bugmail]]

Comment on attachment 311285 [details] [diff] [review]
patch

a=beltzner

Comment 5

[Reed Loden [:reed]]

Checking in browser/components/search/content/search.xml;
/cvsroot/mozilla/browser/components/search/content/search.xml,v  <--  search.xml
new revision: 1.122; previous revision: 1.121
done