search-go-button don't ignore right click

RESOLVED FIXED in Firefox 3

Status

()

Firefox
Search
RESOLVED FIXED
10 years ago
10 years ago

People

(Reporter: sevenfurnace, Assigned: sevenfurnace)

Tracking

({regression})

Trunk
Firefox 3
x86
Linux
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

10 years ago
User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8.1.12) Gecko/20080207 Ubuntu/7.10 (gutsy) Firefox/2.0.0.12
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.9b5pre) Gecko/2008032405 Minefield/3.0b5pre

when right-clicking on the search button of searchbar, search results should not be loaded in the content area.

Reproducible: Always

Steps to Reproduce:
1. Right click the magnifier button on the searchbar.

Actual Results:  
Toolbar-customization popup is opened, and at the same time search results is loaded in the current tab.

Expected Results:  
Toolbar-customization popup is opened.
(Assignee)

Updated

10 years ago
Version: unspecified → Trunk
(Assignee)

Comment 1

10 years ago
Created attachment 311285 [details] [diff] [review]
patch

checks aEvent.button
(Assignee)

Updated

10 years ago
Attachment #311285 - Flags: review?(gavin.sharp)

Comment 2

10 years ago
That's a regression, it did not happen on Firefox 2 or previous nightlies.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Keywords: regression
Comment on attachment 311285 [details] [diff] [review]
patch

Thanks for the patch!
Attachment #311285 - Flags: review?(gavin.sharp)
Attachment #311285 - Flags: review+
Attachment #311285 - Flags: approval1.9?
Comment on attachment 311285 [details] [diff] [review]
patch

a=beltzner
Attachment #311285 - Flags: approval1.9? → approval1.9+
Assignee: nobody → sevenfurnace
Keywords: checkin-needed
Checking in browser/components/search/content/search.xml;
/cvsroot/mozilla/browser/components/search/content/search.xml,v  <--  search.xml
new revision: 1.122; previous revision: 1.121
done
Status: NEW → RESOLVED
Last Resolved: 10 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 3
You need to log in before you can comment on or make changes to this bug.