dtrace no longer compiles as JSFunction.u.n.clasp is no longer available.

RESOLVED FIXED

Status

()

RESOLVED FIXED
11 years ago
11 years ago

People

(Reporter: igor, Assigned: alfred.peng)

Tracking

Trunk
Points:
---
Bug Flags:
in-testsuite -
in-litmus -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

11 years ago
Bug 424376 comment 14 provides the details.
(Reporter)

Updated

11 years ago
Blocks: 424376
No longer depends on: 424376
(Reporter)

Comment 1

11 years ago
(In reply to bug 424376 comment #14)
> igor, any suggestion on the patch?

The patch is fine.

(Assignee)

Comment 2

11 years ago
Posted patch patch v1Splinter Review
It's better to post the patch here. I'll obsolete the old one.
Attachment #311341 - Flags: review?(igor)
(Assignee)

Comment 3

11 years ago
Comment on attachment 311341 [details] [diff] [review]
patch v1

As igor's comment 1 is fine, I'd like to ask for b5 approval for this followup fix.
Attachment #311341 - Flags: approval1.9b5?
(Reporter)

Updated

11 years ago
Attachment #311341 - Flags: review?(igor) → review+
(Reporter)

Comment 4

11 years ago
(In reply to comment #3)
> (From update of attachment 311341 [details] [diff] [review])
> As igor's comment 1 is fine, I'd like to ask for b5 approval for this followup
> fix.

dtrace code is not a part of the default browser build. As such no approval is necessary.

(Assignee)

Updated

11 years ago
Assignee: general → alfred.peng
Keywords: checkin-needed
(Assignee)

Comment 5

11 years ago
Comment on attachment 311341 [details] [diff] [review]
patch v1

Cancel the request for b5 approval per igor's comment above.
Attachment #311341 - Flags: approval1.9b5?
(Reporter)

Comment 6

11 years ago
I checked in the patch from the comment 2 to the trunk:

Checking in jsdtracef.c;
/cvsroot/mozilla/js/src/jsdtracef.c,v  <--  jsdtracef.c
new revision: 3.8; previous revision: 3.7
done
Status: NEW → RESOLVED
Last Resolved: 11 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Flags: in-testsuite-
Flags: in-litmus-

Updated

11 years ago
Blocks: 425744

Updated

11 years ago
No longer blocks: 425744
You need to log in before you can comment on or make changes to this bug.