Closed Bug 424814 Opened 12 years ago Closed 11 years ago
Update Mochitest Prototype Test Suite to 1
.6 .0 .2
The test suite that we have for Prototype is out of date, at this point, it should be upgraded to the latest version: 184.108.40.206.
Assignee: nobody → harthur
Status: NEW → ASSIGNED
Attachment #323788 - Flags: review?(jresig)
updated patch(Hg) does not show changes to random hidden files. Can be applied at top directory.
The failures were determined to be due to the mochitest infrastructure and not any browser bug, so the functions that caused these failures were removed. all tests pass in this patch.
So I just tried to compile the latest attachment and got the following error in building: /Users/jresig/Code/Mozilla/mozilla/firefox-objdir/config/nsinstall -L /Users/jresig/Code/Mozilla/mozilla/firefox-objdir/dom/tests/mochitest/ajax/prototype/dist "/Users/jresig/Code/Mozilla/mozilla/dom/tests/mochitest/ajax/prototype/dist/prototype.js" ../../../../../../_tests/testing/mochitest/tests/dom/tests/mochitest/ajax/prototype/dist make: *** No rule to make target `empty.html', needed by `libs'. Stop. make: *** [libs] Error 2 make: *** [libs] Error 2 make: *** [libs] Error 2 make: *** [libs] Error 2 make: *** [libs] Error 2 make: *** [libs] Error 2 make: *** [libs] Error 2 make: *** [libs_tier_gecko] Error 2 make: *** [tier_gecko] Error 2 make: *** [default] Error 2 make: *** [build] Error 2 Looks like a missing empty.html file?
Heather - plan on getting a new patch on this bug?
Yeah, I'll take a look at this again and see if there's anything I need to clean up.
This patch gets rid of a couple extra ruby files and comments out the test cases that failed on my Windows build (bug 452708 and bug 452706). This also changes a bit of the diagnostic information to reflect the change in directory structure.
Comment on attachment 336001 [details] [diff] [review] patch without extra files and failed test cases I didn't actually run these (assuming you did and that they passed). r=sdwilsh, but fix some of the Makefile.in's you added. The copyright date is wrong, and you should list yourself as a contributor. Thanks!
Attachment #336001 - Flags: review?(sdwilsh) → review+
Component: Testing → DOM
QA Contact: testing → general
Heather, can we get a new patch with Shawn's last changes? You can carry his review forward and I can handle the check-in part.
Patch with updated makefiles list 2008 as copyright date and me as a contributor.
Attachment #336001 - Attachment is obsolete: true
At long last, patch checked in: changeset: 23750:6eb627215b61 --> Fixed
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.