Closed
Bug 424814
Opened 16 years ago
Closed 15 years ago
Update Mochitest Prototype Test Suite to 1.6.0.2
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
People
(Reporter: jeresig, Assigned: harth)
References
Details
Attachments
(1 file, 4 obsolete files)
679.31 KB,
patch
|
Details | Diff | Splinter Review |
The test suite that we have for Prototype is out of date, at this point, it should be upgraded to the latest version: 1.6.0.2.
Assignee | ||
Comment 1•16 years ago
|
||
Updated the prototype test suite in the mochitest harness. Here are the failures induced by this patch: 1. not ok - undefined 0 assertions, 1 failures, 0 errors Failure: assert got <false> Info: These tests are running from rake. This seems to be expected as these tests are not running from rake. 2. not ok - undefined 2 assertions, 1 failures, 0 errors Failure: NOTE: YOU MUST ALLOW JAVASCRIPT TO RESIZE YOUR WINDOW FOR THESE TESTS TO PASS expected <25>, actual: <0>. This is odd because the browser preference for dom.disable_window_move_resize is set to false. Do you think this could be due the mochitest infrastructure as this did not fail when the individual test file was run via mochitest(prototype/test/unit/tmp/dom_test.html). 3. not ok - undefined 0 assertions, 1 failures, 0 errors Failure: assertEqual expected <3>, actual: <2>. This comes from the function testPeriodicalExecutorStop in the file prototype/test/unit/base_test.js (line 279). This seems to be a time-dependent as when the value for waiting (line 288) is changed from 600 to 1200, the test passes. Let me know how to handle these failures.
Assignee | ||
Comment 2•16 years ago
|
||
updated patch(Hg) does not show changes to random hidden files. Can be applied at top directory.
Attachment #323788 -
Attachment is obsolete: true
Attachment #323912 -
Flags: review?(jresig)
Attachment #323788 -
Flags: review?(jresig)
Assignee | ||
Comment 3•16 years ago
|
||
The failures were determined to be due to the mochitest infrastructure and not any browser bug, so the functions that caused these failures were removed. all tests pass in this patch.
Attachment #323912 -
Attachment is obsolete: true
Attachment #327042 -
Flags: review?(jresig)
Attachment #323912 -
Flags: review?(jresig)
Reporter | ||
Comment 4•16 years ago
|
||
So I just tried to compile the latest attachment and got the following error in building: /Users/jresig/Code/Mozilla/mozilla/firefox-objdir/config/nsinstall -L /Users/jresig/Code/Mozilla/mozilla/firefox-objdir/dom/tests/mochitest/ajax/prototype/dist "/Users/jresig/Code/Mozilla/mozilla/dom/tests/mochitest/ajax/prototype/dist/prototype.js" ../../../../../../_tests/testing/mochitest/tests/dom/tests/mochitest/ajax/prototype/dist make[11]: *** No rule to make target `empty.html', needed by `libs'. Stop. make[10]: *** [libs] Error 2 make[9]: *** [libs] Error 2 make[8]: *** [libs] Error 2 make[7]: *** [libs] Error 2 make[6]: *** [libs] Error 2 make[5]: *** [libs] Error 2 make[4]: *** [libs] Error 2 make[3]: *** [libs_tier_gecko] Error 2 make[2]: *** [tier_gecko] Error 2 make[1]: *** [default] Error 2 make: *** [build] Error 2 Looks like a missing empty.html file?
Reporter | ||
Updated•16 years ago
|
Attachment #327042 -
Flags: review?(jresig) → review-
Comment 5•16 years ago
|
||
Heather - plan on getting a new patch on this bug?
Assignee | ||
Comment 6•16 years ago
|
||
Yeah, I'll take a look at this again and see if there's anything I need to clean up.
Assignee | ||
Comment 7•16 years ago
|
||
This patch gets rid of a couple extra ruby files and comments out the test cases that failed on my Windows build (bug 452708 and bug 452706). This also changes a bit of the diagnostic information to reflect the change in directory structure.
Attachment #327042 -
Attachment is obsolete: true
Attachment #336001 -
Flags: review?(sdwilsh)
Comment 8•16 years ago
|
||
Comment on attachment 336001 [details] [diff] [review] patch without extra files and failed test cases I didn't actually run these (assuming you did and that they passed). r=sdwilsh, but fix some of the Makefile.in's you added. The copyright date is wrong, and you should list yourself as a contributor. Thanks!
Attachment #336001 -
Flags: review?(sdwilsh) → review+
Updated•16 years ago
|
Component: Testing → DOM
QA Contact: testing → general
Heather, can we get a new patch with Shawn's last changes? You can carry his review forward and I can handle the check-in part.
Assignee | ||
Comment 10•16 years ago
|
||
Patch with updated makefiles list 2008 as copyright date and me as a contributor.
Attachment #336001 -
Attachment is obsolete: true
Comment 11•15 years ago
|
||
At long last, patch checked in: changeset: 23750:6eb627215b61 --> Fixed
Status: ASSIGNED → RESOLVED
Closed: 15 years ago
Resolution: --- → FIXED
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•